census: Trace annotation for reporting inbound message sizes #9944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge sizes(compressed and uncompressed)
ejona86
approved these changes
Mar 9, 2023
DNVindhya
added a commit
to DNVindhya/grpc-java
that referenced
this pull request
Mar 13, 2023
This commit uses [OpenCensus Annotation][] to report message size [bytes] for inbound/received messages in traces. `addMessageEvent` API which is currently used expects both uncompressed and compressed message (optional) sizes to be reported at the same. Since decompression for messages happens at a later point in time, reporting compressed message as is and reporting uncompressed size as `-1` renders the size as _0 bytes received_ in cloud tracing front end. As a workaround, we add _two annotations for each received message_: * For compressed message size * For uncompressed message size (when it is available) This commit also removes `addMessageEvents` a flag introduced in PR grpc#9485 to temporarily suppress message events for gcp-observability. [OpenCensus Annotation]: https://www.javadoc.io/static/io.opencensus/opencensus-api/0.31.0/io/opencensus/trace/Annotation.html
ejona86
pushed a commit
that referenced
this pull request
Mar 13, 2023
This commit uses [OpenCensus Annotation][] to report message size [bytes] for inbound/received messages in traces. `addMessageEvent` API which is currently used expects both uncompressed and compressed message (optional) sizes to be reported at the same. Since decompression for messages happens at a later point in time, reporting compressed message as is and reporting uncompressed size as `-1` renders the size as _0 bytes received_ in cloud tracing front end. As a workaround, we add _two annotations for each received message_: * For compressed message size * For uncompressed message size (when it is available) This commit also removes `addMessageEvents` a flag introduced in PR #9485 to temporarily suppress message events for gcp-observability. [OpenCensus Annotation]: https://www.javadoc.io/static/io.opencensus/opencensus-api/0.31.0/io/opencensus/trace/Annotation.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses OpenCensus Annotation to report message size [bytes] for inbound/received messages in traces.
addMessageEventAPI which is currently used expects both uncompressed and compressed message (optional) sizes to be reported at the same. Since decompression for messages happens at a later point in time, reporting compressed message as is and reporting uncompressed size as-1renders the size as 0 bytes received in cloud tracing front end.As a workaround, we add two annotations for each received message:
This PR also removes
addMessageEventsa flag introduced in PR #9485 to temporarily suppress message events for gcp-observabilityCC @ejona86 @sanjaypujare