Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 11 building. #593

Merged
merged 3 commits into from
Nov 16, 2018
Merged

Node 11 building. #593

merged 3 commits into from
Nov 16, 2018

Conversation

nicolasnoble
Copy link
Member

Also removing the .travis.yml file since it seems to be confusing people.

@nicolasnoble
Copy link
Member Author

I've filed an issue at mapbox/node-pre-gyp#421 for the node 11 support.

@nicolasnoble nicolasnoble changed the title Node 11 testing and building. Node 11 testing. Nov 4, 2018
@nicolasnoble
Copy link
Member Author

Disabling the node 11 package building until mapbox/node-pre-gyp#422 is in.

@nicolasnoble
Copy link
Member Author

And as a chicken-and-egg paradox, we can't do node 11 testing without shipping node 11 binaries.

@nicolasnoble nicolasnoble changed the base branch from master to grpc@1.16.x November 15, 2018 19:05
@nicolasnoble
Copy link
Member Author

Redoing the whole thing, on the 1.16.x branch, and with node-pre-gyp 0.12.0.

@nicolasnoble nicolasnoble changed the title Node 11 testing. Node 11 building. Nov 15, 2018
@nicolasnoble nicolasnoble merged commit 65f7b72 into grpc:grpc@1.16.x Nov 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants