feat: Add support for mail_settings message field
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the `mail_settings` field of the [mail-send](https://www.twilio.com/docs/sendgrid/api-reference/mail-send/mail-send#request-body) API. This field includes the `sandbox_mode` setting, which allows sending the API to Sendgrid without actually sending the email to the recipient(s), which is useful for testing. Closes gsquire#103
gsquire
requested changes
Oct 10, 2024
When the `bypass_list_management` field is present, the other bypass filters (`bypass_spam_management`, `bypass_bounce_management`, and `bypass_unsubscribe_management`) are ignored. Model this as an enum in the code.
gsquire
approved these changes
Oct 10, 2024
|
Awesome, thanks for this patch. I will push a new release after I do some housekeeping. |
gsquire
added a commit
that referenced
this pull request
Oct 10, 2024
This incorporates #118 for a new release.
Merged
gsquire
added a commit
that referenced
this pull request
Oct 10, 2024
This incorporates #118 for a new release.
|
Alright, version 0.23.0 has these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
mail_settingsfield of the mail-send API. This field includes thesandbox_modesetting, which allows sending the API to Sendgrid without actually sending the email to the recipient(s), which is useful for testing.Closes #103