-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency fixes #1076
Consistency fixes #1076
Conversation
The line on one of your changes states "/* Black prints faster: h5bp.com/s */". Does that mean the using "black" is faster than "#000" perhaps due to parcing? I wonder how one can test this... |
No, that line was already present before the commit. This is for consistency (always use a hex code) |
@tomByrer Black also refers to #000, or rgb(0,0,0). What is happening is that when a document is printed, text that are certain shades of grey take longer to print in some browser. One of the comments in the article stated that there was no speed differences
|
Thanks for the insight @mikealmond! |
Why did you modify the margin on the chromeframe css? I'm -1 on removing the closing tags from the main index file. I'd rather add them back to the 404 |
@necolas I felt the bar looked awkward with a margin on the top but none on the sides. I can revert it back if needed. Part of the reason I removed the closing tags was because of a few PR's that were rejected putting them back in the 404. I'm pro removing tags that don't need to be there, while still making code legible. Basically for me, that's only the html, body and li's on short lists. I thought it would also spark some conversation. I'm good with any decision, I just want it to be consistent. |
-1 for removing closing tags because we should be consistent and if we are being consistent we should also remove closing head tag. +1 for adding quote and changing black to #000 |
All this and more should be addressed in #1112 |
Dealt with as part of 7a2f9dc |
The second commit is to make the index page consistent with the 404 page (#1016). It's a little controversial so I understand if there is a lot of push back.
And... discuss.