Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gulp-autoprefixer task to the project #1681

Closed
wants to merge 2 commits into from
Closed

Added gulp-autoprefixer task to the project #1681

wants to merge 2 commits into from

Conversation

AllThingsSmitty
Copy link
Contributor

Autoprefixer will help keep the CSS cleaner and free of unnecessary/outdated vendor prefixes

@@ -2,6 +2,7 @@ var fs = require('fs');
var path = require('path');

var gulp = require('gulp');
var autoprefixer = require('gulp-autoprefixer');

This comment was marked as abuse.

This comment was marked as abuse.

@alrra
Copy link
Member

alrra commented Mar 11, 2015

@AllThingsSmitty Thanks for the pull request, but IMHO at least, this isn't really needed for this project.

@battaglr
Copy link
Contributor

AFAIK adding Autoprefixer will only allow us to remove the ::-moz-selection declaration, and depending on the browser support, the resolution/density rules —we'll only need to declare (min-resolution: 120dpi). Of course, this will be just on the src/css/main.css file.

It sure will make the CSS a bit cleaner, but not that much.

Unless I'm missing something, I'm 👍 with this.

Edited comment.

@arthurvr
Copy link
Member

I should agree with @alrra here. We don't really need this.

@AllThingsSmitty
Copy link
Contributor Author

I've opened PR #1682 to address the compatibility items.

@arthurvr
Copy link
Member

@AllThingsSmitty You could also have updated this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants