Added gulp-autoprefixer task to the project #1682

AllThingsSmitty · 2015-03-11T14:24:11Z

Addresses compatibility items in PR #1681

arthurvr · 2015-03-11T14:31:16Z

The package.json file is invalid (bad copy-pasting, I guess).

gulpfile.js

-
+
+    return gulp.src('css/main.css')
+                .pipe(plugins.autoprefixer({


AllThingsSmitty · 2015-03-11T14:58:54Z

Thanks, @arthurvr. I've corrected the conflicts in the gulpfile and package.json

gulpfile.js

-               .pipe(gulp.dest(dirs.dist + '/css'));
-
+                .pipe(plugins.autoprefixer({
+                    browsers: ['last 2 versions', 'ie >= 8'],


mathiasbynens · 2015-03-13T10:15:36Z

LGTM

ghost · 2015-03-13T11:13:00Z

To make things official, is there any chance similar to this could be added to the documentation? https://github.com/google/web-starter-kit/blob/master/README.md#browser-support

gulpfile.js

@@ -103,8 +103,11 @@ gulp.task('copy:main.css', function () {

    return gulp.src(dirs.src + '/css/main.css')
               .pipe(plugins.header(banner))
+               .pipe(plugins.autoprefixer({
+                    browsers: ['last 2 versions', 'ie >= 8'],


alrra · 2015-03-13T11:32:47Z

To make things official, is there any chance similar to this could be added to the documentation? https://github.com/google/web-starter-kit/blob/master/README.md#browser-support

@corvannoorloos Adding exact version numbers isn't a good idea as they rapidly get outdated (e.g. in your link FF 30, 31, Chrome 34, 35, etc.) (Cc: @sindresorhus, @addyosmani)

However, I think it would be nice to state that we support the latest 2 versions in the cases where a lower version isn't specified (e.g. as in the case of IE).

To make things official

@corvannoorloos Pull request welcomed!

sindresorhus · 2015-03-13T12:07:02Z

👍 Yeah, don't use fixed versions.

battaglr · 2015-03-13T12:16:41Z

Adding exact version numbers isn't a good idea as they rapidly get outdated [...].

However, I think it would be nice to state that we support the latest 2 versions in the cases where a lower version isn't specified (e.g. as in the case of IE).

@alrra: 👍

@corvannoorloos: let me know if you will take this one, if not I'll be glad to do it.

ghost · 2015-03-13T12:49:32Z

@alrra 👍

@battaglr go ahead. I'm at work for at least a couple of hours.

alrra · 2015-03-13T20:44:20Z

Merged with some modifications. Thanks @AllThingsSmitty!

Ref h5bp/html5-boilerplate#1682 h5bp/html5-boilerplate#1682 (comment) https://github.com/postcss/autoprefixer https://github.com/sindresorhus/gulp-autoprefixer Close h5bp/html5-boilerplate#1682

Added gulp-autoprefixer task to the project

aa56069

AllThingsSmitty mentioned this pull request Mar 11, 2015

Added gulp-autoprefixer task to the project #1681

Closed

arthurvr reviewed Mar 11, 2015
View reviewed changes

gulpfile.js

return gulp.src('css/main.css')

.pipe(plugins.autoprefixer({

This comment was marked as abuse.

Sign in to view

AllThingsSmitty added 2 commits March 11, 2015 10:51

Resolved conflicts from last commit

07fc6b9

Fixed package.json syntax

aacc9c4

battaglr reviewed Mar 11, 2015
View reviewed changes

Added missing semicolon

54ede96

alrra reviewed Mar 13, 2015
View reviewed changes

alrra added the enhancement label Mar 13, 2015

Updated autoprefixer target browser list

f9bd590

battaglr mentioned this pull request Mar 13, 2015

Add detailed info about browser support #1684

Closed

alrra closed this in c7057be Mar 13, 2015

ghost mentioned this pull request Mar 14, 2015

Partially revert vendor prefixes #1685

Closed

alrra mentioned this pull request Apr 7, 2015

Warning about use of dpi in main.css #1474

Closed

alrra mentioned this pull request Dec 6, 2015

Update browser-support section from README.md google/web-starter-kit#790

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added gulp-autoprefixer task to the project #1682

Added gulp-autoprefixer task to the project #1682

AllThingsSmitty commented Mar 11, 2015

arthurvr commented Mar 11, 2015

This comment was marked as abuse.

AllThingsSmitty commented Mar 11, 2015

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

mathiasbynens commented Mar 13, 2015

ghost commented Mar 13, 2015

This comment was marked as abuse.

This comment was marked as abuse.

alrra commented Mar 13, 2015

sindresorhus commented Mar 13, 2015

battaglr commented Mar 13, 2015

ghost commented Mar 13, 2015

alrra commented Mar 13, 2015

Added gulp-autoprefixer task to the project #1682

Added gulp-autoprefixer task to the project #1682

Conversation

AllThingsSmitty commented Mar 11, 2015

arthurvr commented Mar 11, 2015

This comment was marked as abuse.

AllThingsSmitty commented Mar 11, 2015

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

mathiasbynens commented Mar 13, 2015

ghost commented Mar 13, 2015

This comment was marked as abuse.

This comment was marked as abuse.

alrra commented Mar 13, 2015

sindresorhus commented Mar 13, 2015

battaglr commented Mar 13, 2015

ghost commented Mar 13, 2015

alrra commented Mar 13, 2015