Add daily mean ecco dataset to catalog #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaceKuailv
requested review from
malmans2,
renskegelderloos,
ThomasHaine,
asiddi24 and
Mikejmnez
as code owners
|
The error in CI you are getting is related to issue #332 , independent of the changes within this PR. I got another fix for the issue in #332 , but I am having some trouble trying to install a testing environment in Sciserver to check that the error goes away. Mitya is helping me, hopefully will get a PR fixing issue #332 later today... |
Mikejmnez
approved these changes
Mar 24, 2023
|
@MaceKuailv don't forget to run pre-commit to get all the formatting right |
|
I am doing the pre-commit right now. I didn't realize that this part also have format constraints. |
Mikejmnez
pushed a commit
to Mikejmnez/oceanspy
that referenced
this pull request
Mar 26, 2023
* Add daily mean ecco dataset to catalog * missing style changes
Mikejmnez
added a commit
that referenced
this pull request
Mar 26, 2023
* update packages * update env * allow earlier versions * Add daily mean ecco dataset to catalog (#333) * Add daily mean ecco dataset to catalog * missing style changes --------- Co-authored-by: Miguel Jimenez <mjimen17@jhu.edu> Co-authored-by: MaceKuailv <52629492+MaceKuailv@users.noreply.github.com>
|
Thanks @MaceKuailv and @Mikejmnez! I'll make an announcement on https://www.poseidon-ocean.net/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the catalog for daily ecco