Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: whatif input provider #233

Merged
merged 1 commit into from
Feb 10, 2021
Merged

feat: whatif input provider #233

merged 1 commit into from
Feb 10, 2021

Conversation

roleyfoley
Copy link
Contributor

Description

AWS implementation of hamlet-io/engine#1538

Motivation and Context

Adds AWS support for the whatif provider which combines the mock and composite provider behaviour to work on existing CMDBs

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

Adds AWS support for the whatif provider which combines the mock and
composite provider behaviour to work on existing CMDBs
@roleyfoley roleyfoley requested a review from a team February 4, 2021 08:14
Copy link
Contributor

@RossMurr4y RossMurr4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once hamlet-io/engine#1538 has been merged into master/main.

@RossMurr4y RossMurr4y merged commit 71b5e7a into hamlet-io:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants