feat: whatif input provider #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whatif input provider allows you to use your composite CMDB to create and query deployments before actually deplyowing the changes you've made in your CMDB Input sources are primarily handled the same way as the composite input source except for StackOutputs. The whatif provider checks to see if a composite stack output can be found and if it can't then it will return a mocked output instead This allows you to add components to a CMDB to see what they will create before deploying any of their required components
10 tasks
RossMurr4y
reviewed
Feb 8, 2021
| [#return result] | ||
| [/#function] | ||
|
|
||
| [#function internalReformatFiles key settingsFiles fileRegex] |
There was a problem hiding this comment.
A comment here on the purpose of the reformat would be helpful. A lot of reading is required to understand the desired final format.
There was a problem hiding this comment.
I moved these functions from composite to the shared provider so they would be available to both providers. Writing these functions wasn't part of this change
RossMurr4y
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1535
Motivation and Context
The whatif input provider allows you to use a composite CMDB to create and query deployments before actually deploying the changes you've made in your CMDB
Input sources are primarily handled the same way as the composite input source except for StackOutputs. The whatif provider checks to see if a composite stack output can be found and if it can't then it will return a mocked output instead
This allows you to add components to a CMDB to see what they will create before deploying any of their required components. This is really helpful when generating diagrams or running through demonstrations where you don't want to wait for deployments to complete
How Has This Been Tested?
Tested locally
Types of changes
Followup Actions
Checklist: