engine: keep the same lint with tiflow repo #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
force-pushed
the
keep-the-same-lint-as-tiflow
branch
from
1d69be8
to
73a711a
Compare
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
================================================
- Coverage 54.9763% 54.9036% -0.0728%
================================================
Files 135 135
Lines 10590 10584 -6
================================================
- Hits 5822 5811 -11
- Misses 4317 4320 +3
- Partials 451 453 +2 |
amyangfei
force-pushed
the
keep-the-same-lint-as-tiflow
branch
from
73a711a
to
181d9ad
Compare
7 tasks
maxshuang
reviewed
May 11, 2022
maxshuang
reviewed
May 11, 2022
maxshuang
approved these changes
May 11, 2022
Co-authored-by: maxshuang <huangguohao@pingcap.com>
Co-authored-by: maxshuang <huangguohao@pingcap.com>
amyangfei
commented
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pingcap/tiflow enables two more CI linters to check exported variable/function comments. Dataflow engine is better to follow the same rule.
EXC0012andEXC0014for part of packageslib,jobmaster, andexecutor/workerwill be enabled in another PRref: pingcap/tiflow#5352