Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task lists for merging dataflow engine into pingcap/tiflow #5352

Closed
7 tasks done
amyangfei opened this issue May 7, 2022 · 1 comment
Closed
7 tasks done

Task lists for merging dataflow engine into pingcap/tiflow #5352

amyangfei opened this issue May 7, 2022 · 1 comment
Assignees
@amyangfei
Labels
type/feature Issues about a new feature

Comments

@amyangfei
Copy link
Contributor

amyangfei commented May 7, 2022 •
edited
Loading

Is your feature request related to a problem?

This issue lists tasks to do for merging dataflow engine into pingcap/tiflow

Describe the feature you'd like

  1. merge the main code base and make CI happy.
  2. Update issue template, add dataflow engine. ref: config(tiflow): add area/engine label to tiflow repo ti-community-infra/configs#575, contributing(all): update minimal go version, add engine in commit message #5522
  3. Update readme of tiflow repo, adding introduction of dataflow engine.
  4. Update CI required fields.
  5. Add dataflow engine into verify CI, ref: *: support verify CI #3153, ci(engine): support verify ci for dataflow engine #5501, verify-ci: add dataflow engine in verify ci PingCAP-QE/devops-config#128
  6. Optimize CI scripts, skip DM/TiCDC integration tests when only updating engine code. ci: skip ticdc integration tests if matching engine dir PingCAP-QE/ci#940
  7. Make dataflow engine lint compatible with tiflow repo. ref: engine: keep the same lint with tiflow repo hanfei1991/microcosm#379

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response
@amyangfei amyangfei added the type/feature Issues about a new feature label May 7, 2022
@amyangfei amyangfei mentioned this issue May 7, 2022
Merged
amyangfei added a commit to amyangfei/tiflow that referenced this issue May 7, 2022
@amyangfei
engine: fix dataflow engine build (pingcap#5352)
ecc865a 
- add copyright to all dataflow engine go files
- update import path of dataflow engine
- disable ci lint in engine
- update error toml
- refine check copyright script
@amyangfei amyangfei mentioned this issue May 7, 2022
Merged
@amyangfei amyangfei self-assigned this May 7, 2022
@amyangfei amyangfei mentioned this issue May 13, 2022
Merged
amyangfei added a commit to amyangfei/tiflow that referenced this issue May 19, 2022
@amyangfei
engine: fix dataflow engine build (pingcap#5352)
04997a2
amyangfei added a commit to amyangfei/tiflow that referenced this issue May 19, 2022
@amyangfei
engine: fix dataflow engine build (pingcap#5352)
c4e07d0
amyangfei added a commit to amyangfei/tiflow that referenced this issue May 19, 2022
@amyangfei
engine: fix dataflow engine build (pingcap#5352)
f0bd027
amyangfei added a commit to amyangfei/tiflow that referenced this issue May 20, 2022
@amyangfei
engine: fix dataflow engine build (pingcap#5352)
020b4a7
amyangfei added a commit to amyangfei/tiflow that referenced this issue May 20, 2022
@amyangfei
engine: fix dataflow engine build (pingcap#5352)
399645f
amyangfei added a commit to amyangfei/tiflow that referenced this issue May 20, 2022
@amyangfei
engine: fix dataflow engine build (pingcap#5352)
eff3f2d
This was referenced May 20, 2022
Merged
Merged
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue May 23, 2022
@amyangfei
contributing(all): update minimal go version, add engine in commit me…
8c90140 
…ssage (#5522)

ref #5352
ti-chi-bot pushed a commit that referenced this issue May 23, 2022
@amyangfei
ci(engine,dm): enable dataflow engine e2e test in dm (#5537)
fa3d50d 
ref #5352
ti-chi-bot pushed a commit that referenced this issue May 24, 2022
@amyangfei
ci(engine): support verify ci for dataflow engine (#5501)
41fcb9f 
ref #5352
@amyangfei
Copy link
Contributor Author

amyangfei commented May 30, 2022 •
edited
Loading

Will update readme of dataflow engine in next month (June).

@amyangfei amyangfei mentioned this issue May 30, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue May 30, 2022
@amyangfei
test(engine): remove unit test from Github Action. (#5651)
728c693 
ref #5352
This was referenced Jun 1, 2022
Closed
Merged
ti-chi-bot pushed a commit that referenced this issue Jun 2, 2022
@amyangfei
errdoc(engine): remove dataflow engine from error doc generator (#5721)
44af201 
ref #5352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amyangfei amyangfei

Labels
type/feature Issues about a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amyangfei