Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Highlight rabbits with requirement #1874

Merged
merged 5 commits into from
May 30, 2024

Conversation

superhize
Copy link
Contributor

@superhize superhize commented May 24, 2024

What

Highlight rabbits that have requirements in the Hoppity Collection menu.

Changelog New Features

  • Highlight rabbits that have requirements in the Hoppity's Collection menu. - HiZe
    • Green: Requirement met.
    • Red: Requirement not met.

@hannibal002 hannibal002 added this to the Version 0.26 milestone May 24, 2024
@CalMWolfs
Copy link
Collaborator

Can we also get an option to only show the red on not unlocked ones and otherwise show nothing, also this whole setting should probably be default off as there are probably quite a few people that dont have m7 completion that dont want to see red highlighted slots by default

@hannibal002 hannibal002 changed the title Add: Highlight rabbits with requirement Feature: Highlight rabbits with requirement May 25, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 26, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 28, 2024
Copy link

Conflicts have been resolved! 🎉

@superhize superhize requested a review from CalMWolfs May 28, 2024 17:00
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked fine

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 29, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label May 30, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityCollectionStats.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 30, 2024
Copy link

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 merged commit a6133f8 into hannibal002:beta May 30, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label May 30, 2024
@superhize superhize deleted the unlocked_rabbits branch June 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants