Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Change colour (UK) to color (US) #2258

Merged
merged 2 commits into from
Jul 28, 2024
Merged

Backend: Change colour (UK) to color (US) #2258

merged 2 commits into from
Jul 28, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Jul 25, 2024

What

For consistency, we change all usages of colour to color.

Only exceptions in this PR:

  • @ConfigEditorColour (From MoulConfig)
  • Utils.chromaStringByColourCode() (From NotEnoughUpdates)
  • Config names (Added To-dos to all of them, might change a ton/all config rename To-dos in a later pr at once)
Without this PR

image
image

With this PR

image
image

Changelog Technical Details

  • Changed "colour" to "color" internally, everywhere. - hannibal2

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jul 25, 2024
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jul 25, 2024
@Thunderblade73
Copy link
Contributor

Please at that info in the contribution guidelines. So that there can't any confusions in the future.

@hannibal002 hannibal002 changed the title Backend: color > colour Backend: use color over colour Jul 25, 2024
@hannibal002 hannibal002 changed the title Backend: use color over colour Backend: Change colour (UK) to color (US) Jul 25, 2024
@nea89o
Copy link
Contributor

nea89o commented Jul 25, 2024

Are there any calls on other American vs British language? I still learned British English, so that is what I am used to, even beyond -our vs -or: -ise vs -ize, -ogue vs -og, etc.

@hannibal002 hannibal002 merged commit b2082d1 into beta Jul 28, 2024
9 checks passed
@hannibal002 hannibal002 deleted the color branch July 28, 2024 08:01
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants