Continue cleanup of HalfEdge
#1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue the cleanup of
HalfEdgethat I started in #1521 and #1522. This leavesHalfEdgein something of an in-between state, as I've run out of time to work on this today.The next step is to inline
VertexintoHalfEdge. The goal here is to removeVertexcompletely, but I believe it will have to stay for a transition phase, as some code isn't quite ready to live without it. After that, I have more ideas, like only storing a singleSurfaceVertexinHalfEdge, to reduce the redundancy betweenHalfEdges in aCycleand the need for validation. We'll see how that works out.