Demote Vertex from its status as an object, embed it in HalfEdge
#1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is preparation for some simplifications of `HalfEdge`/`Vertex` that I'm currently working on.
This is preparation for some simplifications of `HalfEdge`/`Vertex` that I'm currently working on.
This is preparation for some simplifications of `HalfEdge`/`Vertex` that I'm currently working on.
This is preparation for some simplifications of `HalfEdge`/`Vertex` that I'm currently working on.
This is preparation for some simplifications of `HalfEdge`/`Vertex` that I'm currently working on.
While `Vertex` instances could, in theory, be shared between different `HalfEdge`s, this isn't currently done, and I don't think it would provide any advantage. Therefore, having `Vertex` be a separate object doesn't make any sense and only makes the object graph more complicated. This is the first step towards rectifying this and simplifying the object graph around `HalfEdge`.
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From one of the commit messages:
I have more ideas for simplifications in that part of the object graph, but at this point it's unclear how directly applicable those are, or whether other foundational cleanups are required first.