Updates to hapi 18; refactors cache.engine to cache.provider #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we planning to publish this change anytime soon? We are planning to migrate to hapi 18 but need Glue to be hapi 18 compatible. |
csrl
approved these changes
Jan 22, 2019
|
It looks like we'll have to do a major glue release, since it breaks compatibility. |
|
Yeah unfortunately I think you’re right.
I considered keeping `engines` in the manifest and just mapping it to
prevent breaking , but it felt wrong to have that server option mismatch.
…On Tue, Jan 22, 2019 at 7:40 AM csrl ***@***.***> wrote:
It looks like we'll have to do a major glue release, since it breaks
compatibility.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#124 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALl4O6zpTXDip-mWIBeiUxKB_wHCl_Dkks5vFxS_gaJpZM4aJWb8>
.
|
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I'm not 100% sure, but I believe from checking the Release Notes that these cache.engine ->> cache.provider manifest and config renames are the only changes for server provisioning.
Let me know if there's anything I need to change, or if I missed anything. :)