Migrate to hapi 17, node 8 and async/await closes #568 #572

corbinu · 2017-12-12T18:31:02Z

Migrates to hapi 17, node 8 and async/await

I removed wreck support as wreck no longer issues the events needed

I am still trying to solve an issue where the tests emit MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 end listeners added. Use emitter.setMaxListeners() to increase limit

Any comments and help would be appreciated

arb · 2017-12-12T20:52:02Z

lib/utils.js


        const req = request.raw.req;
        const res = request.raw.res;

        this.event = 'response';
        this.timestamp = request.info.received;
        this.id = request.id;
-        this.instance = request.connection.info.uri;
-        this.labels = request.connection.settings.labels;
+        this.instance = server.info.uri;


Is the server not exposed in the request anymore?

I followed the upgrade instructions in the release notes for this. I also just searched the API docs page for uri and only see it as ever being attached to the server

arb · 2017-12-12T20:54:49Z

lib/monitor.js

    }

    startOps(interval) {

        this._ops && this._ops.start(interval);
    }

-    start(callback) {
+    start() {


So since we are cutting ties with old versions of hapi and node, you can rewrite

const ctorArgs = spec.args ? spec.args.slice() : []; ctorArgs.unshift(null); Ctor = Ctor.bind.apply(Ctor, ctorArgs); const stream = new Ctor();

to use rest parameters. Not sure if you were planning on a subsequent JavaScript updates PR or not.

Should be a one-liner with rest parameters.

Nice catch I also removed the use of arguments bellow that

arb · 2017-12-12T20:55:47Z

lib/monitor.js

@@ -187,9 +154,10 @@ class Monitor {
            });
        }

-        return callback();
+        return Promise.resolve();


Is this needed?

Honestly no as the callback that was there before wasn't needed the whole function is synchronous. However I assume it was there to avoid confusion. At first I made the function async but then I got this linting error
Line 75: require-await - Async method 'start' has no 'await' expression.

I mean can you just not return anything? As you said, this isn't even an async function.

arb · 2017-12-12T21:00:19Z

lib/index.js

-
-    pkg: require('../package.json')
-};
+exports.pkg = require('../package.json');


Why this change?

The plugin format has changed without it you get this error

[1] "name" is required at Object.exports.apply (/root/node_modules/hapi/lib/config.js:22:10) at internals.Server.register (/root/node_modules/hapi/lib/server.js:384:31) at it (/root/test/index.js:70:22) at Immediate.setImmediate (/root/node_modules/lab/lib/runner.js:566:31) at runCallback (timers.js:800:20) at tryOnImmediate (timers.js:762:5) at processImmediate [as _immediateCallback] (timers.js:733:5)

Hmmm, you're sure that this works? According to the error message you have to provide exports.name in addition.

@frankthelen Yes I am sure the error was provided simply by switching it back and running the test suit to see it fail. pkg can be used as well please see the very last paragraph and code example here: https://hapijs.com/api

Cool. You're right.

corbinu

Comments have been fixed or replied to. Let me know if I need to do anything else. Thanks so much!

corbinu · 2017-12-13T19:45:55Z

lib/monitor.js

@@ -187,9 +154,10 @@ class Monitor {
            });
        }

-        return callback();
+        return Promise.resolve();


Honestly no as the callback that was there before wasn't needed the whole function is synchronous. However I assume it was there to avoid confusion. At first I made the function async but then I got this linting error
Line 75: require-await - Async method 'start' has no 'await' expression.

corbinu · 2017-12-13T19:48:35Z

lib/utils.js


        const req = request.raw.req;
        const res = request.raw.res;

        this.event = 'response';
        this.timestamp = request.info.received;
        this.id = request.id;
-        this.instance = request.connection.info.uri;
-        this.labels = request.connection.settings.labels;
+        this.instance = server.info.uri;


I followed the upgrade instructions in the release notes for this. I also just searched the API docs page for uri and only see it as ever being attached to the server

corbinu · 2017-12-13T20:03:58Z

lib/monitor.js

    }

    startOps(interval) {

        this._ops && this._ops.start(interval);
    }

-    start(callback) {
+    start() {


Nice catch I also removed the use of arguments bellow that

corbinu · 2017-12-13T20:06:00Z

lib/index.js

-
-    pkg: require('../package.json')
-};
+exports.pkg = require('../package.json');


The plugin format has changed without it you get this error

[1] "name" is required at Object.exports.apply (/root/node_modules/hapi/lib/config.js:22:10) at internals.Server.register (/root/node_modules/hapi/lib/server.js:384:31) at it (/root/test/index.js:70:22) at Immediate.setImmediate (/root/node_modules/lab/lib/runner.js:566:31) at runCallback (timers.js:800:20) at tryOnImmediate (timers.js:762:5) at processImmediate [as _immediateCallback] (timers.js:733:5)

arb · 2017-12-15T16:06:10Z

README.md


-});
+console.info(`Server started at ${ server.info.uri }`);


We should add something about the supported versions of hapi somewhere in the readme.

What format do you want this in. I looked at all the other plugins in the hapi namespace and didn't see an others doing this as was just going to follow whatever format was there.

@arb Just wanted to check if you had a chance to think about this. Don't mean to rush know we all get busy just excited ;)

Put it high in the README. Doesn't matter to me what the format is, just so long as it's there so when people open issues complaining, it is documented.

arb · 2017-12-15T16:10:08Z

lib/monitor.js

@@ -187,9 +154,10 @@ class Monitor {
            });
        }

-        return callback();
+        return Promise.resolve();


I mean can you just not return anything? As you said, this isn't even an async function.

arb · 2017-12-15T16:10:22Z

lib/monitor.js

@@ -207,8 +169,9 @@ class Monitor {

        // Do a setImmediate here so that all the streams listening for "end" have a chance to run
        // https://github.com/nodejs/node/blob/master/lib/_stream_readable.js#L894-L897
-        setImmediate(callback);
+        return new Promise((resolve) => setImmediate(() => resolve()));


Curious if we still need this?

If so you can write it as return new Promise((resolve) => setImmediate(resolve));

I don't think so so removing

teddmason · 2017-12-21T10:18:12Z

I've just gone through upgrading a couple of apps to Hapi 17 and have also upgraded our good logging to @corbinu 's fork, all looking good for us, so far, thank you

arb · 2017-12-21T14:40:25Z

Thanks @corbinu for taking care of this migration!

lock · 2020-01-09T02:12:06Z

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

corbinu force-pushed the master branch from fad46ce to 1d7eb18 Compare December 12, 2017 20:21

arb suggested changes Dec 12, 2017

View reviewed changes

corbinu force-pushed the master branch from 1d7eb18 to 551e136 Compare December 13, 2017 20:01

corbinu commented Dec 13, 2017

View reviewed changes

corbinu changed the title ~~Migrate to hapi 17, node 8 and async/await~~ Migrate to hapi 17, node 8 and async/await closes #568 Dec 14, 2017

arb added this to the 8.0.0 milestone Dec 15, 2017

arb self-assigned this Dec 15, 2017

arb reviewed Dec 15, 2017

View reviewed changes

arb suggested changes Dec 15, 2017

View reviewed changes

corbinu force-pushed the master branch from 551e136 to 893eeb7 Compare December 15, 2017 19:38

Migrate to hapi 17, node 8 and async/await

44b0e21

corbinu force-pushed the master branch from 893eeb7 to 44b0e21 Compare December 20, 2017 00:27

arb added the breaking changes Change that can breaking existing code label Dec 21, 2017

arb approved these changes Dec 21, 2017

View reviewed changes

arb merged commit 9ec13aa into hapijs:master Dec 21, 2017

This was referenced Dec 21, 2017

hapi v17 support #568

Closed

Support latest hapi only #512

Closed

This was referenced Dec 28, 2017

Maintainers wanted creditkarma/good-influx#9

Closed

Maintainers wanted fhemberger/good-logstash#5

Open

lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to hapi 17, node 8 and async/await closes #568 #572

Migrate to hapi 17, node 8 and async/await closes #568 #572

corbinu commented Dec 12, 2017 •

edited

Loading

arb Dec 12, 2017

corbinu Dec 13, 2017

arb Dec 12, 2017

corbinu Dec 13, 2017

arb Dec 12, 2017

corbinu Dec 13, 2017

arb Dec 15, 2017

corbinu Dec 15, 2017

arb Dec 12, 2017

corbinu Dec 13, 2017

frankthelen Dec 14, 2017

corbinu Dec 14, 2017 •

edited

Loading

frankthelen Dec 15, 2017

corbinu left a comment

corbinu Dec 13, 2017

corbinu Dec 13, 2017

corbinu Dec 13, 2017

corbinu Dec 13, 2017

arb Dec 15, 2017

corbinu Dec 15, 2017 •

edited

Loading

corbinu Dec 19, 2017

arb Dec 19, 2017

corbinu Dec 20, 2017

arb Dec 15, 2017

arb Dec 15, 2017

corbinu Dec 15, 2017

teddmason commented Dec 21, 2017

arb commented Dec 21, 2017

lock bot commented Jan 9, 2020

Migrate to hapi 17, node 8 and async/await closes #568 #572

Migrate to hapi 17, node 8 and async/await closes #568 #572

Conversation

corbinu commented Dec 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

corbinu Dec 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

corbinu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

corbinu Dec 15, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teddmason commented Dec 21, 2017

arb commented Dec 21, 2017

lock bot commented Jan 9, 2020

corbinu commented Dec 12, 2017 •

edited

Loading

corbinu Dec 14, 2017 •

edited

Loading

corbinu Dec 15, 2017 •

edited

Loading