Hoek.clone() issues

[kanongil]

I happened to look into the clone() implementation, and found several critical issues in my review:

1. Cloned Map / Set values are completely broken.
2. Does not clone Symbol() properties on object. Can be found using Object.getOwnPropertySymbols().
3. Non-enumerable properties are enumerable on cloned object.
4. Cloned Promise values are broken.

[kanongil]

Another type that could use special handling is Error.

I know that due to lazy evaluation, reading the stack property is extremely slow in V8, and should be avoided. I would probably cheat a little here, and install a getter instead, which can then retrieve the original stack value.

Object.defineProperty(newObj, 'stack', {
    configurable: true,
    get() {

        return obj.stack;
    },
    set(value) {

        Object.defineProperty(newObj, 'stack', {
            configurable: true,
            writable: true,
            value
        });
    }
});

See https://bugs.chromium.org/p/v8/issues/detail?id=5962 for a bit of background.

[nlf]

yup, clone hasn't been updated for newer types (even as new as Promise)

good catch on cloned non-enumerable properties becoming enumerable though!

[robmcguinness]

For completeness: Hoek.applyToDefaults also doesn't take into account Symbol properties of an object.

[SimonSchick]

It's also problematic for complex types such as sockets, I ran into this this catbox-redis just now.

[kanongil]

@SimonSchick Yeah, any object with hidden state won't work unless explicitly added. It's only designed to work for "simple" objects.

[hueniverse]

@kanongil any plans on fixing this?

[kanongil]

The enumerable issue is fixed with 6f02157.

[kanongil]

The Symbol issue should be fixed with #281.

[shijiebei2014]

const Hoek = require('hoek')
var map = new Map([
['1', new Object()]
])
console.log(Hoek.clone(map))

The result is : Map {}

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.