Symbol support #281
Merged
Symbol support #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2018
Closed
hueniverse
reviewed
Nov 28, 2018
| const objSymbols = getOwnPropertySymbols(obj); | ||
| const refSymbols = new Set(getOwnPropertySymbols(ref)); | ||
|
|
||
| for (let i = 0; i < objSymbols.length; ++i) { |
There was a problem hiding this comment.
Use for...of in the future.
There was a problem hiding this comment.
Will do. Maybe we should update the style guide?
|
This is actually a breaking change since most tests where objects have symbols will fail as-is. |
|
Going to change deepEqual to ignore symbols by default for now. |
hueniverse
added a commit
that referenced
this pull request
Nov 28, 2018
Closed
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Symbolsupport to all relevant api methods.