Allow for passing IJSHandle as argument to EvaluateFunctionAsync/EvaluateFunctionHandleAsync #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uateFunctionHandleAsync - Update ExecutionContext.FormatArgument to match IJSHandle instead of JSHandle - Make RemoteObjectHelper class static - Move JSHandle.FormatArgument to RemoteObjectHelper.FormatArgument (extension method) - IJSHandle.RemoteObject fix xml doc
kblok
reviewed
Nov 8, 2022
amaitland
force-pushed
the
enhancement/allowpassingijshandle
branch
from
c56cee2
to
c5a3b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change is to allow for PuppeteerSharp.Dom to pass it's custom
DOMobject instances asIJSHandleargs to EvaluateFunctionAsync/EvaluateFunctionHandleAsync.Currently you have to cast to
JSHandle. e.g. https://github.com/ChromiumDotNet/PuppeteerSharp.Dom/blob/b1f862ee24dcc2a025dfea43d198597dbdedf17c/PuppeteerSharp.Dom.Tests/ElementHandleTests/BoundingBoxTests.cs#L61