Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for passing IJSHandle as argument to EvaluateFunctionAsync/EvaluateFunctionHandleAsync #2038

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Allow for passing IJSHandle as argument to EvaluateFunctionAsync/EvaluateFunctionHandleAsync #2038

merged 2 commits into from
Nov 17, 2022

Commits on Nov 8, 2022

  1. Allow for passing IJSHandle as argument to EvaluateFunctionAsync/Eval… 

    …uateFunctionHandleAsync

- Update ExecutionContext.FormatArgument to match IJSHandle instead of JSHandle
- Make RemoteObjectHelper class static
- Move JSHandle.FormatArgument to RemoteObjectHelper.FormatArgument (extension method)
- IJSHandle.RemoteObject fix xml doc
    @amaitland
    amaitland committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    1f74b05 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Move FormatArgument from RemoteObjectHelper to PuppeteerHandleExtensions 

    Review feedback
    @amaitland
    amaitland committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    c5a3b39 View commit details
    Browse the repository at this point in the history