[SPD-23899] (feat): make compute column liquid tag #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix rounding off issue
* added validator for expressions and also added tests for it * added tests and fixed bugs * fix
* added moment library * allow date and term calculation in liquid * refactor addDuration and subtractDates * return values directly * Fix duration in days calculation * add tests * Maintain consistency in naming decorators * use existing decorators to calculate date term calculation * spell check * remove functions that are not needed * WIP: tests updated * Co-authored-by: Madhav Bhagat <madhav89@gmail.com> tests for add duration and subrtract date * return duration instead of no of days * add default argument for getObjectValues function * handle from_date greater than to_date case * update tests for negative value of durationInDays * support for adding durartion and tests for the same * added tests for assign * throw error if either value or type is incorrcect in duration calculation. Co-authored-by: Sumanth Subbarao <sumanth@Sumanths-MacBook-Pro.local>
Fix type case issue
Update with upstream
Render issue fix
…tests from vscode (#12) Co-authored-by: Shubham <shubham@spotdraft.com>
Co-authored-by: Sumanth Subbarao <sumanth@Sumanths-MacBook-Pro.local>
* return 0 days if duration in days is less than 0 * add tests from null duration Co-authored-by: Sumanth Subbarao <sumanth@Sumanths-MacBook-Pro.local>
* set time to start of day before calculation of days * added return for case not supported Co-authored-by: Shubham <shubham@spotdraft.com>
…tation (#16) Co-authored-by: Shubham <shubham@spotdraft.com>
* refactored code for null values and added tests * added isNan in valid number check Co-authored-by: Shubham <shubham@spotdraft.com>
Co-authored-by: Shubham <shubham@spotdraft.com>
Co-authored-by: Shubham Uniyal <shubham@Shubhams-MacBook-Pro.local>
Co-authored-by: Shubham Uniyal <shubham@Shubhams-MacBook-Pro.local>
* fixed redundant tests * Added tests and made changes in logic for null computation Co-authored-by: Shubham <shubham@spotdraft.com>
* added separate tag for returning variable value from appending vars * added tests Co-authored-by: Shubham <shubham@spotdraft.com>
Co-authored-by: Shubham <shubham@spotdraft.com>
* Add test and method to get dependecy tree for a single assign tag * Change the return type of parseAssign * Handle if else conditions * add test for complex template * Add function to transverse the graph to get affected variables * Add comments * Obfuscate test vars
…check Added function and tests for cyclic dependency check
…27) Co-authored-by: Sanket Mishra <sanket@spotdraft.com>
* added null operation handling for different operations * Added tests for liquid and updated code * Added comments * updated comments Co-authored-by: Shubham <shubham@spotdraft.com>
* add new tag- parseAssign * remove .only from describe in parseAssign test Co-authored-by: Sanket Mishra <sanket@spotdraft.com>
Co-authored-by: Sanket Mishra <sanket@spotdraft.com>
…31) * support comparision of commonform data types directly using operators * remove country_code check for phone number Co-authored-by: Sanket Mishra <sanket@spotdraft.com>
Co-authored-by: Sanket Mishra <sanket@spotdraft.com>
Co-authored-by: Sanket Mishra <sanket@spotdraft.com>
feat: add new dependency method to get all vars that are assigned a value
… summing the values of a specified key in each object. (#36) * add sum filter * use performOperations in sumArray to get the sum * resolved comments * nit * nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new tag compute Column , that takes input dynamic table name and column to compute and runs the computation on the table and assigns column the computed value.