Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add join-node workarounds for SSL cases #462

Merged
merged 3 commits into from
Oct 16, 2023
Merged

doc: add join-node workarounds for SSL cases #462

merged 3 commits into from
Oct 16, 2023

Conversation

starbops
Copy link
Member

@starbops starbops commented Oct 2, 2023 •
edited
Loading

@harvesterhci-io-github-bot
Copy link
Collaborator

harvesterhci-io-github-bot commented Oct 2, 2023 •
edited
Loading

✅ Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit ef81ec1
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/6528f9a830e4aa0ac1ba7796
😎 Deploy Preview https://6528f9a830e4aa0ac1ba7796--harvester-preview.netlify.app

@starbops starbops force-pushed the doc-4511 branch 2 times, most recently from 755c8ad to 8103a19 Compare October 3, 2023 09:58
@starbops starbops changed the title doc: add workaround for SSL and FQDN cases doc: add join-node workarounds for SSL cases Oct 3, 2023
@starbops starbops marked this pull request as ready for review October 3, 2023 09:59
@bk201
Copy link
Member

bk201 commented Oct 5, 2023

@starbops the doc also needs to be in version v1.3 (dev).

@starbops starbops mentioned this pull request Oct 5, 2023
Closed
@starbops
doc: add join-node workarounds for SSL cases
9f8b66b 
Signed-off-by: Zespre Chang <zespre.chang@suse.com>
@starbops
Copy link
Member Author

starbops commented Oct 6, 2023

@bk201 v1.3 updated, PTAL. Thanks!

ibrokethecloud
ibrokethecloud approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

w13915984028
w13915984028 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@w13915984028 w13915984028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bk201
bk201 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@starbops starbops mentioned this pull request Oct 12, 2023
Closed
LucasSaintarbor
LucasSaintarbor reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made formatting and grammar changes + small NITs. Lmk if these changes are okay, thanks!

docs/install/iso-install.md Outdated Show resolved Hide resolved
docs/install/iso-install.md Outdated Show resolved Hide resolved
docs/install/iso-install.md Outdated Show resolved Hide resolved
docs/install/iso-install.md Outdated Show resolved Hide resolved
docs/install/iso-install.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/install/iso-install.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/install/iso-install.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/install/iso-install.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/install/iso-install.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/install/iso-install.md Outdated Show resolved Hide resolved
@starbops
Update wording
9a9a358 
Signed-off-by: Zespre Chang <zespre.chang@suse.com>
@starbops
Change name of CA file to avoid conflict
ef81ec1 
Signed-off-by: Zespre Chang <zespre.chang@suse.com>
@starbops
Copy link
Member Author

I've updated the CA file name from additional-ca.pem to embedded-rancher-ca.pem to avoid potential conflicts and confusion with the additional-ca setting. This also aligns with the PR rancher/rancherd#33.

@w13915984028
Copy link
Member

BTW: Also mention the issue and workaround in #468 against the management-address.md.

@w13915984028 w13915984028 mentioned this pull request Oct 13, 2023
Open
LucasSaintarbor
LucasSaintarbor approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@LucasSaintarbor LucasSaintarbor merged commit 216c41a into harvester:main Oct 16, 2023
1 check passed
@LucasSaintarbor LucasSaintarbor modified the milestones: v1.1.2, v1.2.1 Oct 23, 2023
@starbops starbops mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@ibrokethecloud ibrokethecloud ibrokethecloud approved these changes

@w13915984028 w13915984028 w13915984028 approved these changes

@LucasSaintarbor LucasSaintarbor LucasSaintarbor approved these changes

@jillian-maroket jillian-maroket Awaiting requested review from jillian-maroket

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.
6 participants
@starbops @harvesterhci-io-github-bot @bk201 @w13915984028 @ibrokethecloud @LucasSaintarbor