Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VIP picture and IP address requirements #468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

w13915984028
Copy link
Member

Update VIP picture and IP address requirements

Signed-off-by: Jian Wang <w13915984028@gmail.com>

Issue: https://github.com/harvester/docs/issues/465

@harvesterhci-io-github-bot
Copy link
Collaborator

harvesterhci-io-github-bot commented Oct 12, 2023

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit 1583ab8
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/65297556c29f771cd80d3849
😎 Deploy Preview https://65297556c29f771cd80d3849--harvester-preview.netlify.app

Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made formatting and grammar changes + small NITs. Lmk if these changes are okay, thanks!

docs/install/requirements.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.2/install/requirements.md Outdated Show resolved Hide resolved
@w13915984028
Copy link
Member Author

Note: After the #462 is merged, we can further polish the management-address.md with the workaround in Harvester doc.

Signed-off-by: Jian Wang <w13915984028@gmail.com>
@jillian-maroket jillian-maroket requested review from jillian-maroket and removed request for LucasSaintarbor October 18, 2023 08:49
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w13915984028 Let me know if the changes work.

@@ -13,12 +13,18 @@ Description: The Harvester provides a virtual IP as the management address.

Harvester provides a fixed virtual IP (VIP) as the management address, VIP must be different from any Node IP. You can find the management address on the console dashboard after the installation.

The VIP is configured while the **first Node** of the cluster is installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The VIP is configured while the **first Node** of the cluster is installed.
The VIP is configured while the **first node** of the Harvester cluster is installed.

:::note

If you selected the IP address to be configured via DHCP, you will need to configure static MAC-to-IP address mapping on your DHCP server in order to have a persistent Virtual IP

:::

After the Node starts successfully, both of the VIP and Node IP are shown on the console.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After the Node starts successfully, both of the VIP and Node IP are shown on the console.
Both the node IP and cluster VIP are displayed on the console after the node starts successfully.

Comment on lines +51 to +53
After the first Node of the Harvester cluster is installed, user may configure the [ssl-certificates](../advanced/settings.md#ssl-certificates), then the cluster can be accessed via VIP and FQDN.

The following installed Node can also join the cluster by both VIP and FQDN. When using FQDN, please note a known issue [Unable to join the new node](https://github.com/harvester/harvester/issues/4511) and workaround: https://github.com/harvester/harvester/issues/4511#issuecomment-1761047115
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After the first Node of the Harvester cluster is installed, user may configure the [ssl-certificates](../advanced/settings.md#ssl-certificates), then the cluster can be accessed via VIP and FQDN.
The following installed Node can also join the cluster by both VIP and FQDN. When using FQDN, please note a known issue [Unable to join the new node](https://github.com/harvester/harvester/issues/4511) and workaround: https://github.com/harvester/harvester/issues/4511#issuecomment-1761047115
You can configure [SSL certificate settings](../advanced/settings.md#ssl-certificates) after the first cluster node is installed. SSL certificates allow you to access and join nodes to the cluster using VIPs and FQDNs.
However, in some cases you may be [unable to join a new node to a cluster](https://github.com/harvester/harvester/issues/4511) using FQDNs. If you encounter this issue, you can follow the steps in [this workaround](https://github.com/harvester/harvester/issues/4511#issuecomment-1761047115).

@@ -42,6 +42,16 @@ A three-node cluster is required to realize the multi-node features of Harvester

Harvester nodes have the following network requirements for installation.

### IP Address Requirements for Harvester Nodes

Harvester is built on top of Kubernetes, and each node needs an independent IP address. Harvester uses this IP address to identify a node identity, and it cannot change during the lifecycle of a Harvester cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Harvester is built on top of Kubernetes, and each node needs an independent IP address. Harvester uses this IP address to identify a node identity, and it cannot change during the lifecycle of a Harvester cluster.
Each node in a Harvester cluster must have an independent IP address. Harvester uses this IP to verify the node's identity so the IP must not change throughout the lifecycle of the cluster.

@@ -13,12 +13,18 @@ Description: The Harvester provides a virtual IP as the management address.

Harvester provides a fixed virtual IP (VIP) as the management address, VIP must be different from any Node IP. You can find the management address on the console dashboard after the installation.

The VIP is configured while the **first Node** of the cluster is installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The VIP is configured while the **first Node** of the cluster is installed.
The VIP is configured while the **first node** of the Harvester cluster is installed.

Comment on lines +49 to +53
### IP Address Requirements for Harvester Cluster

The Harvester cluster needs an additional IP address called Virtual IP (VIP). It uses it as the management IP for the whole cluster.

Please refer to [Management Address](./management-address.md) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### IP Address Requirements for Harvester Cluster
The Harvester cluster needs an additional IP address called Virtual IP (VIP). It uses it as the management IP for the whole cluster.
Please refer to [Management Address](./management-address.md) for more details.
### IP Address Requirements for Harvester Clusters
Each Harvester cluster must have a fixed virtual IP (VIP) that is different from all other node IPs. Harvester uses this VIP as the [management address](./management-address.md) for the cluster.

Comment on lines +49 to +53
### IP Address Requirements for Harvester Cluster

The Harvester cluster needs an additional IP address called Virtual IP (VIP). It uses it as the management IP for the whole cluster.

Please refer to [Management Address](./management-address.md) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### IP Address Requirements for Harvester Cluster
The Harvester cluster needs an additional IP address called Virtual IP (VIP). It uses it as the management IP for the whole cluster.
Please refer to [Management Address](./management-address.md) for more details.
### IP Address Requirements for Harvester Clusters
Each Harvester cluster must have a fixed virtual IP (VIP) that is different from all other node IPs. Harvester uses this VIP as the [management address](./management-address.md) for the cluster.

@@ -42,6 +42,16 @@ A three-node cluster is required to realize the multi-node features of Harvester

Harvester nodes have the following network requirements for installation.

### IP Address Requirements for Harvester Nodes

Harvester is built on top of Kubernetes, and each node needs an independent IP address. Harvester uses this IP address to identify a node identity, and it cannot change during the lifecycle of a Harvester cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Harvester is built on top of Kubernetes, and each node needs an independent IP address. Harvester uses this IP address to identify a node identity, and it cannot change during the lifecycle of a Harvester cluster.
Each node in a Harvester cluster must have an independent IP address. Harvester uses this IP to verify the node's identity so the IP must not change throughout the lifecycle of the cluster.

@@ -13,12 +13,18 @@ Description: The Harvester provides a virtual IP as the management address.

Harvester provides a fixed virtual IP (VIP) as the management address, VIP must be different from any Node IP. You can find the management address on the console dashboard after the installation.

The VIP is configured while the **first Node** of the cluster is installed.

e.g. ![Configure the VIP mode and IP address in ISO Installation](/img/v1.2/install/config-virtual-ip.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
e.g. ![Configure the VIP mode and IP address in ISO Installation](/img/v1.2/install/config-virtual-ip.png)
Example:
![Configure the cluster VIP and node IP during ISO Installation](/img/v1.2/install/config-virtual-ip.png)

@@ -13,12 +13,18 @@ Description: The Harvester provides a virtual IP as the management address.

Harvester provides a fixed virtual IP (VIP) as the management address, VIP must be different from any Node IP. You can find the management address on the console dashboard after the installation.

The VIP is configured while the **first Node** of the cluster is installed.

e.g. ![Configure the VIP mode and IP address in ISO Installation](/img/v1.2/install/config-virtual-ip.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
e.g. ![Configure the VIP mode and IP address in ISO Installation](/img/v1.2/install/config-virtual-ip.png)
Example:
![Configure the cluster VIP and node IP during ISO Installation](/img/v1.2/install/config-virtual-ip.png)

@w13915984028
Copy link
Member Author

w13915984028 commented Oct 19, 2023

@jillian-maroket Thanks for your comment.

Could you please have a pre-check of @LucasSaintarbor 's comment. Some descriptions have already been updated per comments.

Hopefully, we don't need to continuously update the document due to different reviewer have different favourites.

And, for the added parts, we also try to keep content/description/format similar with the existing contents.

thanks.

@LucasSaintarbor
Copy link
Contributor

@jillian-maroket Thanks for your comment.

Could you please have a pre-check of @LucasSaintarbor 's comment. Some descriptions have already been updated per comments.

Hopefully, we don't need to continuously update the document due to different reviewer have different favourites.

And, for the added parts, we also try to keep content/description/format similar with the existing contents.

thanks.

Hi @w13915984028, sorry for the double review. I wanted @jillian-maroket to review this PR for practice and she made some formatting/grammar suggestions I missed. This won't be a normal occurrence moving forward but we should go with her review on this PR. Thanks!

@LucasSaintarbor
Copy link
Contributor

@w13915984028 May you review the changes suggested by @jillian-maroket when you get the chance? Can https://github.com/harvester/docs/issues/465 be closed?

@w13915984028
Copy link
Member Author

@LucasSaintarbor I will rebase and recheck the PR, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants