Use existing reference to container element instead of reselecting. #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2013
|
looks good |
|
Looks good to me too. |
Conflicts: chosen/chosen.jquery.js chosen/chosen.jquery.min.js chosen/chosen.proto.js chosen/chosen.proto.min.js
pfiller
added a commit
that referenced
this pull request
Apr 19, 2013
…nces Use existing reference to container element instead of reselecting.
|
When do you think this fix will be available as a released version now that it's been merged into the master branch? |
|
If you pull down master of Chosen now, this is available. Master is always the latest and greatest of Chosen. We're going to tag the latest changes before wrapping up for the weekend and hopefully get these files pushed out to the documentation pages as well. |
|
Yea, I know I can get it from the master, but we have a policy at work not to pull from master branches. We're only allowed to grab officially tagged releases, hence my question. Thanks for the clarification! |
pfiller
added a commit
that referenced
this pull request
Apr 19, 2013
Better container reference #1151 Fix issue when destroying last choice #1149 Use selectedIndex for tracking change events. #1147 Better IE Disabling #1144 Dropdown use css positioning for top position #1143 Fix bug when deleting last item #1142 Percentage Width Support #1141 CSS Centering Fix #1120 Use New CoffeeScript #1125 Chosen License #1111 Update placeholder text with ``liszt:updated`` #1107 Fix strange event bubbling #1055
|
@elwayman02 the tag is updated. Chosen is now 0.9.13 |
This was referenced Apr 24, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves usage when Chosen is being created on elements in memory (as opposed to elements that already exist in the dom). It removes the need to create a separate variable for storing the div in the jQuery version and makes the same adjustment in the Prototype version.
Fixes #183