Simple change for more efficient and less error-prone container var assignment #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that you are only assigning the container var to match the same action as prototype ($(selector)), but it doesn't make sense in jQuery since the container element is already assigned to
container_div
.This just makes it so you don't rely on the ID and just assign the var directly, it still matches the Prototype version in terms of form. I ran into a bug where the code would break because it could not find the container via ID since it was not yet registered in the visible DOM.