Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple change for more efficient and less error-prone container var assignment #504

Closed
wants to merge 4 commits into from

Conversation

kmiyashiro
Copy link

I understand that you are only assigning the container var to match the same action as prototype ($(selector)), but it doesn't make sense in jQuery since the container element is already assigned to container_div.

This just makes it so you don't rely on the ID and just assign the var directly, it still matches the Prototype version in terms of form. I ran into a bug where the code would break because it could not find the container via ID since it was not yet registered in the visible DOM.

@stof
Copy link
Collaborator

stof commented Sep 3, 2012

@pfiller any chance to have it merged ?

@pfiller
Copy link
Contributor

pfiller commented Apr 18, 2013

Closing in favor of #1151 which also kills the container_div reference. Thanks for pointing this out @kmiyashiro.

@pfiller pfiller closed this Apr 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants