Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect NODE_NAMES #925

Merged
merged 6 commits into from
Jul 16, 2024
Merged

fix: incorrect NODE_NAMES #925

merged 6 commits into from
Jul 16, 2024

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Jul 16, 2024 •
edited
Loading

Description

This pull request changes the following:

  • Fix incorrect NODE_NAMES environment variables
  • Add logic to check haproxy pod status

Related Issues

@JeffreyDallas
save
b1ff2a8 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
check proxy status
2ab7523 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
revert
8412bdd 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from a team as code owners July 16, 2024 17:22
@JeffreyDallas JeffreyDallas marked this pull request as draft July 16, 2024 17:23
@JeffreyDallas
save
2c3d42c 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
save
64fec94 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas changed the title fix: fix incorrect NODE_NAMES fix: incorrect NODE_NAMES Jul 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

Unit Test Results

  26 files  ±0    26 suites  ±0   1m 11s ⏱️ +10s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 7fab555. ± Comparison against base commit 0416b44.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (0416b44) to head (7fab555).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #925   +/-   ##
=========================================
  Coverage     67.17%   67.17%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1319     1319           
  Branches        157      157           
=========================================
  Hits            886      886           
  Misses          370      370           
  Partials         63       63

Impacted file tree graph

@JeffreyDallas
save
7fab555 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas marked this pull request as ready for review July 16, 2024 18:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JeffreyDallas JeffreyDallas merged commit 81629a8 into main Jul 16, 2024
20 of 21 checks passed
@JeffreyDallas JeffreyDallas deleted the 00924-D-fix-nodenames branch July 16, 2024 19:35
swirlds-automation added a commit that referenced this pull request Aug 1, 2024
@swirlds-automation
chore(release): 0.29.0 [skip ci]
5bb8a74 
## [0.29.0](v0.28.3...v0.29.0) (2024-08-01)

### Features

* add extra container for sidecar uploader ([#926](#926)) ([58ff515](58ff515))

### Bug Fixes

* haproxy fails to start ([#921](#921)) ([e162d3d](e162d3d))
* incorrect NODE_NAMES ([#925](#925)) ([81629a8](81629a8))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

@rbarkerSL rbarkerSL Awaiting requested review from rbarkerSL rbarkerSL is a code owner automatically assigned from hashgraph/devops-ci

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

During CI test, only node0 is started
3 participants
@JeffreyDallas @swirlds-automation @jeromy-cannon