Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add extra container for sidecar uploader #926

Merged
merged 11 commits into from
Jul 26, 2024
Merged

feat: add extra container for sidecar uploader #926

merged 11 commits into from
Jul 26, 2024

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • Add another pod for hosting sidecar uploader

Related Issues

@JeffreyDallas
save
f670b62 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
fix
65a7808 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
save
d082464 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
revert
5d677e7 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
Merge commit '81629a86a083c02c2a0a1e66bc279c59908961fa' into 00919-D-…
6a64445 
…upload-sidear

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
save
d85f397 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from a team as code owners July 17, 2024 21:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Unit Test Results

  26 files  ±0    26 suites  ±0   1m 12s ⏱️ +6s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit a9ea2b3. ± Comparison against base commit f1af076.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (f1af076) to head (a9ea2b3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #926   +/-   ##
=========================================
  Coverage     67.17%   67.17%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1319     1319           
  Branches        157      157           
=========================================
  Hits            886      886           
  Misses          370      370           
  Partials         63       63

Impacted file tree graph

Ivo-Yankov
Ivo-Yankov requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@Ivo-Yankov Ivo-Yankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you also add one more change to fullstack-deployment/values.yaml: Set this value hedera.mirror.importer.parser.record.sidecar.enabled=true. This will enable the importing of sidecar records to the mirror node.

@JeffreyDallas JeffreyDallas marked this pull request as draft July 18, 2024 14:27
@georgi-l95 georgi-l95 mentioned this pull request Jul 19, 2024
Open
@JeffreyDallas
save
b8f3e11 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas marked this pull request as ready for review July 24, 2024 16:53
@JeffreyDallas
Merge branch 'main' into 00919-D-upload-sidear
a700793 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
save
3facbea 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Ivo-Yankov
Ivo-Yankov approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@Ivo-Yankov Ivo-Yankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeffreyDallas
add sleep to wait uploader up
9a559c8 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
fix file name
a9ea2b3 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JeffreyDallas JeffreyDallas merged commit 58ff515 into main Jul 26, 2024
18 checks passed
@JeffreyDallas JeffreyDallas deleted the 00919-D-upload-sidear branch July 26, 2024 01:52
@Ivo-Yankov Ivo-Yankov mentioned this pull request Jul 26, 2024
Closed
swirlds-automation added a commit that referenced this pull request Aug 1, 2024
@swirlds-automation
chore(release): 0.29.0 [skip ci]
5bb8a74 
## [0.29.0](v0.28.3...v0.29.0) (2024-08-01)

### Features

* add extra container for sidecar uploader ([#926](#926)) ([58ff515](58ff515))

### Bug Fixes

* haproxy fails to start ([#921](#921)) ([e162d3d](e162d3d))
* incorrect NODE_NAMES ([#925](#925)) ([81629a8](81629a8))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@JeffreyDallas JeffreyDallas mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leninmehedy leninmehedy leninmehedy left review comments

@Ivo-Yankov Ivo-Yankov Ivo-Yankov approved these changes

@matteriben matteriben Awaiting requested review from matteriben matteriben is a code owner automatically assigned from hashgraph/release-engineering

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu is a code owner automatically assigned from hashgraph/devops-ci

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Record stream files under sidecar directory is not uploaded
4 participants
@JeffreyDallas @swirlds-automation @leninmehedy @Ivo-Yankov