-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Updating GitHub actions to use semantic versioning. #16598
base: main
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16598 +/- ##
==========================================
Coverage 64.27% 64.27%
Complexity 20885 20885
==========================================
Files 2549 2549
Lines 95976 95976
Branches 10043 10043
==========================================
Hits 61690 61690
Misses 30656 30656
Partials 3630 3630 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good! A few --very minor-- change requests and then it looks like we'll need to generate an NPM_TOKEN
c0338a4
to
4dd189d
Compare
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
4dd189d
to
f3856c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Has this been tested yet?
@andrewb1269hg @san-est
I have a meeting with Nathan and Roger tomorrow to chat about the appropriate testing process to ensure we test this adequately before merging it to the mainline. |
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
77f22da
to
d5b496a
Compare
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
@@ -44,7 +44,8 @@ tasks.named("closeSonatypeStagingRepository") { | |||
|
|||
tasks.named("releaseMavenCentral") { | |||
group = "release" | |||
dependsOn(tasks.closeAndReleaseStagingRepository) | |||
// dependsOn(tasks.closeAndReleaseStagingRepository) | |||
dependsOn(tasks.named("closeSonatypeStagingRepository")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging #15282 this can be controlled via a parameter to the ./gradlew
call in the GH actions flow.
-PpublishTestRelease=true
will usecloseSonatypeStagingRepository
-PpublishTestRelease=false
(or no parameter) will usecloseAndReleaseStagingRepository
This and the other parameters will be documented here: https://github.com/hiero-ledger/hiero-gradle-conventions/tree/documentation?tab=readme-ov-file#in-github-actions (docs are wip right now)
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Testing snapshot publish was successful today. Official releases (i.e. 99.99.99 or alpha production releases) both failed. The issue is being investigated at this time. |
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
…ph/hedera-services into semantic-release-workflow-update
@rbarkerSL @nathanklick I believe this is PR is ready for review. There are a couple of follow-up items I'd like to discuss:
|
Description:
This PR aims to update the release workflows to use semantic versioning. The changes that have been done are re-work of node-flow-deploy-release-artifact.yaml and node-zxc-build-release-artifact.yaml. I've also added .releaserc.json.
Related issue(s):
Fixes #14967
Fixes #11781
Notes for reviewer:
Checklist