Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updating GitHub actions to use semantic versioning. #16598

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

san-est
Copy link
Contributor

@san-est san-est commented Nov 14, 2024

Description:
This PR aims to update the release workflows to use semantic versioning. The changes that have been done are re-work of node-flow-deploy-release-artifact.yaml and node-zxc-build-release-artifact.yaml. I've also added .releaserc.json.

Related issue(s):

Fixes #14967
Fixes #11781

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@san-est san-est added the github_actions Pull requests that update GitHub Actions code label Nov 14, 2024
@san-est san-est added this to the v0.57 milestone Nov 14, 2024
@san-est san-est self-assigned this Nov 14, 2024
Copy link

codacy-production bot commented Nov 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1e4a206) 95739 65129 68.03%
Head commit (d0aee00) 95739 (+0) 65129 (+0) 68.03% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16598) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.27%. Comparing base (1e4a206) to head (d0aee00).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16598   +/-   ##
==========================================
  Coverage      64.27%   64.27%           
  Complexity     20885    20885           
==========================================
  Files           2549     2549           
  Lines          95976    95976           
  Branches       10043    10043           
==========================================
  Hits           61690    61690           
  Misses         30656    30656           
  Partials        3630     3630           

Impacted file tree graph

Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good! A few --very minor-- change requests and then it looks like we'll need to generate an NPM_TOKEN

@san-est san-est force-pushed the semantic-release-workflow-update branch from c0338a4 to 4dd189d Compare November 15, 2024 16:34
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
@san-est san-est force-pushed the semantic-release-workflow-update branch from 4dd189d to f3856c7 Compare November 15, 2024 16:39
@san-est san-est marked this pull request as ready for review November 18, 2024 08:46
@san-est san-est requested review from a team as code owners November 18, 2024 08:46
@san-est san-est requested a review from leninmehedy November 18, 2024 08:46
rbarkerSL
rbarkerSL previously approved these changes Nov 19, 2024
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Has this been tested yet?
@andrewb1269hg @san-est

@andrewb1269hg
Copy link
Contributor

I have a meeting with Nathan and Roger tomorrow to chat about the appropriate testing process to ensure we test this adequately before merging it to the mainline.

Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
@andrewb1269hg andrewb1269hg force-pushed the semantic-release-workflow-update branch from 77f22da to d5b496a Compare December 6, 2024 19:13
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
@@ -44,7 +44,8 @@ tasks.named("closeSonatypeStagingRepository") {

tasks.named("releaseMavenCentral") {
group = "release"
dependsOn(tasks.closeAndReleaseStagingRepository)
// dependsOn(tasks.closeAndReleaseStagingRepository)
dependsOn(tasks.named("closeSonatypeStagingRepository"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging #15282 this can be controlled via a parameter to the ./gradlew call in the GH actions flow.

  • -PpublishTestRelease=true will use closeSonatypeStagingRepository
  • -PpublishTestRelease=false (or no parameter) will use closeAndReleaseStagingRepository

This and the other parameters will be documented here: https://github.com/hiero-ledger/hiero-gradle-conventions/tree/documentation?tab=readme-ov-file#in-github-actions (docs are wip right now)

Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
@andrewb1269hg
Copy link
Contributor

Testing snapshot publish was successful today.

Official releases (i.e. 99.99.99 or alpha production releases) both failed. The issue is being investigated at this time.

Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
…ph/hedera-services into semantic-release-workflow-update
@andrewb1269hg
Copy link
Contributor

@rbarkerSL @nathanklick I believe this is PR is ready for review. There are a couple of follow-up items I'd like to discuss:

  1. Are there additional changes required to workflows to enable publishing through workflows?
  2. When do we need to apply the temp tag for 0.58.0 in this process? Before or after this PR merges to mainline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
4 participants