Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use common Hiero Gradle config #15282

Merged
merged 22 commits into from
Dec 18, 2024
Merged

Conversation

jjohannes
Copy link
Collaborator

@jjohannes jjohannes commented Aug 30, 2024

Description:

Before this can be integrated:

Related issue(s):

#14255

@jjohannes jjohannes self-assigned this Aug 30, 2024
@jjohannes jjohannes added this to the v0.55 milestone Sep 2, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 2 times, most recently from 9f31f6d to c629b6e Compare September 2, 2024 07:11
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 4 times, most recently from df441df to a1831af Compare September 6, 2024 14:22
Copy link

codacy-production bot commented Sep 6, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+2.07% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (753d1be) 98565 64922 65.87%
Head commit (9239739) 95563 (-3002) 64921 (-1) 67.94% (+2.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15282) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.19%. Comparing base (753d1be) to head (9239739).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #15282      +/-   ##
=============================================
- Coverage      64.19%   64.19%   -0.01%     
- Complexity     20815    20817       +2     
=============================================
  Files           2548     2548              
  Lines          95800    95800              
  Branches       10028    10028              
=============================================
- Hits           61498    61496       -2     
- Misses         30687    30688       +1     
- Partials        3615     3616       +1     

see 8 files with indirect coverage changes

Impacted file tree graph

@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 3 times, most recently from 6dcaef1 to 056f81a Compare September 9, 2024 06:24
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 056f81a to 4294d00 Compare September 16, 2024 06:53
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 4294d00 to 4f0a5cc Compare September 16, 2024 08:17
@jjohannes jjohannes changed the base branch from develop to jendrik-dev-tmp September 16, 2024 08:18
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 2 times, most recently from 6289854 to d24e59a Compare September 22, 2024 16:38
@jjohannes jjohannes force-pushed the jendrik-dev-tmp branch 2 times, most recently from 9e1eace to a89aea7 Compare September 26, 2024 16:51
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 4 times, most recently from feb92cd to 9010124 Compare September 30, 2024 08:34
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 9010124 to 28b89bb Compare September 30, 2024 13:33
@jjohannes jjohannes removed this from the v0.55 milestone Oct 1, 2024
@jjohannes jjohannes requested a review from mhess-swl December 12, 2024 16:23
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
mhess-swl
mhess-swl previously approved these changes Dec 12, 2024
vtronkov
vtronkov previously approved these changes Dec 13, 2024
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
@jjohannes jjohannes dismissed stale reviews from vtronkov and mhess-swl via 1aac63f December 17, 2024 07:32
@jjohannes
Copy link
Collaborator Author

Playing ping-pong with Dependabot with the PR... needed to rebase several times due to conflicts with version updates.

Could you please restore your approval so that we get this in before the next conflict blocks it again.

@thomas-swirlds-labs @rbarkerSL @Neeharika-Sompalli @lpetrovic05 @mhess-swl @vtronkov

Much appreciated. 🙏

This no longer exists.

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to:
.github/CODEOWNERS
.github/workflows/config/node-release.yaml
.github/workflows/node-flow-deploy-release-artifact.yaml
.github/workflows/node-zxc-build-release-artifact.yaml
.github/workflows/node-zxcron-release-fsts-regression.yaml
.github/workflows/platform-zxcron-release-jrs-regression.yaml
.github/workflows/zxc-publish-production-image.yaml
.github/workflows/zxc-verify-docker-build-determinism.yaml

Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked only at hedera-node/hedera-smart-contract-service-impl/src/main/java/module-info.java - LGTM

@jjohannes jjohannes merged commit c4e3cf6 into develop Dec 18, 2024
47 checks passed
@jjohannes jjohannes deleted the 14255-reusable-gradle-config branch December 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants