-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use common Hiero Gradle config #15282
Conversation
9f31f6d
to
c629b6e
Compare
df441df
to
a1831af
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15282 +/- ##
=============================================
- Coverage 64.19% 64.19% -0.01%
- Complexity 20815 20817 +2
=============================================
Files 2548 2548
Lines 95800 95800
Branches 10028 10028
=============================================
- Hits 61498 61496 -2
- Misses 30687 30688 +1
- Partials 3615 3616 +1 |
6dcaef1
to
056f81a
Compare
056f81a
to
4294d00
Compare
4294d00
to
4f0a5cc
Compare
6289854
to
d24e59a
Compare
9e1eace
to
a89aea7
Compare
feb92cd
to
9010124
Compare
a89aea7
to
57ed309
Compare
9010124
to
28b89bb
Compare
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Playing ping-pong with Dependabot with the PR... needed to rebase several times due to conflicts with version updates. Could you please restore your approval so that we get this in before the next conflict blocks it again. @thomas-swirlds-labs @rbarkerSL @Neeharika-Sompalli @lpetrovic05 @mhess-swl @vtronkov Much appreciated. 🙏 |
This no longer exists. Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review applies to:
.github/CODEOWNERS
.github/workflows/config/node-release.yaml
.github/workflows/node-flow-deploy-release-artifact.yaml
.github/workflows/node-zxc-build-release-artifact.yaml
.github/workflows/node-zxcron-release-fsts-regression.yaml
.github/workflows/platform-zxcron-release-jrs-regression.yaml
.github/workflows/zxc-publish-production-image.yaml
.github/workflows/zxc-verify-docker-build-determinism.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked only at hedera-node/hedera-smart-contract-service-impl/src/main/java/module-info.java
- LGTM
Description:
Before this can be integrated:
Related issue(s):
#14255