feat: enhance node add to work with staking and dynamic address book #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
…211 are hardcoded in JS SDK that will not work when running locally or in a pipeline Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
…solo into 00381-D-staking-nodes Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # add_node.sh # src/commands/node.mjs # test/test_util.js # version.mjs
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
…pping when only one node Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
E2E Mirror Node Tests Coverage Report 1 files ±0 1 suites ±0 5m 9s ⏱️ +6s Results for commit fd366cd. ± Comparison against base commit ef0199f. This pull request removes 4 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
E2E Relay Tests Coverage Report1 files ±0 1 suites ±0 3m 32s ⏱️ -6s Results for commit fd366cd. ± Comparison against base commit ef0199f. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> # Conflicts: # resources/templates/application.properties # src/core/helpers.mjs
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
- Coverage 82.02% 81.42% -0.60%
==========================================
Files 35 35
Lines 4216 4414 +198
Branches 727 755 +28
==========================================
+ Hits 3458 3594 +136
- Misses 758 818 +60
- Partials 0 2 +2
... and 1 file with indirect coverage changes |
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
nathanklick
approved these changes
Aug 14, 2024
swirlds-automation
added a commit
that referenced
this pull request
Aug 26, 2024
## [0.28.0](v0.27.0...v0.28.0) (2024-08-26) ### Features * add freeze account ([#436](#436)) ([8fe5a41](8fe5a41)) * enhance node add to work with staking and dynamic address book ([#469](#469)) ([b452599](b452599)) * use k8s configMaps to mount files during solo network deploy ([#345](#345)) ([af27f16](af27f16)) ### Bug Fixes * hugo jsdoc failure ([#498](#498)) ([ff07413](ff07413)) * reduce number of account used e2e init account test ([#477](#477)) ([51d7ade](51d7ade)) * Resolve various problems to enable tests from local-node and smart-contracts to run agains solo network ([#402](#402)) ([c99d881](c99d881)) * use path.join instead of forward slashes to support Windows ([#491](#491)) ([82a5053](82a5053))
|
🎉 This PR is included in version 0.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
application.properties: setstaking.periodMins=1to reduce node stake weight calculation to 1 minute instead of 24 hourslog4j2.xml:OnStartupTriggeringPolicyto reset log file but preserve it with a rollover file namesettings.txt:event.migrateEventHashing, falseto prevent 0.52 to 0.53 migration logic, this is not needed since we are testing an upgrade from 0.53.x to 0.53.xsolo node addflags to support new dynamic address book functionalityRelated Issues