fix: use path.join instead of forward slashes to support Windows #491

jeromy-cannon · 2024-08-16T13:12:23Z

Description

This pull request changes the following:

use path.join instead of forward slashes to support Windows

Related Issues

Closes Use path.join instead of forward slash when solo is using file paths on local system to avoid windows issues #490

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> # Conflicts: # src/core/profile_manager.mjs # test/unit/core/profile_manager.test.mjs

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

github-actions · 2024-08-16T13:19:39Z

Unit Test Results - Linux

1 files 19 suites 46s ⏱️
124 tests 124 ✅ 0 💤 0 ❌
150 runs 150 ✅ 0 💤 0 ❌

Results for commit 0fc9e9d.

github-actions · 2024-08-16T13:21:18Z

Unit Test Results - Windows

1 files 19 suites 1m 32s ⏱️
124 tests 124 ✅ 0 💤 0 ❌
150 runs 150 ✅ 0 💤 0 ❌

Results for commit 0fc9e9d.

github-actions · 2024-08-16T13:22:19Z

E2E Node PEM Stop Tests Coverage Report

12 tests 12 ✅ 2m 37s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 0fc9e9d.

github-actions · 2024-08-16T13:22:22Z

E2E Relay Tests Coverage Report

1 files 1 suites 2m 40s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs 6 ✅ 0 💤 0 ❌

Results for commit 0fc9e9d.

github-actions · 2024-08-16T13:22:31Z

E2E Node PFX Kill Tests Coverage Report

12 tests 12 ✅ 2m 48s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 0fc9e9d.

github-actions · 2024-08-16T13:23:47Z

E2E Tests Coverage Report

59 tests 59 ✅ 4m 6s ⏱️
9 suites 0 💤
1 files 0 ❌

Results for commit 0fc9e9d.

github-actions · 2024-08-16T13:24:44Z

E2E Node Local Build Tests Coverage Report

8 tests 8 ✅ 2m 43s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit 0fc9e9d.

github-actions · 2024-08-16T13:25:46Z

E2E Node Add Tests Coverage Report

9 tests 9 ✅ 6m 17s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 0fc9e9d.

github-actions · 2024-08-16T13:28:58Z

E2E Mirror Node Tests Coverage Report

1 files 1 suites 3m 42s ⏱️
12 tests 12 ✅ 0 💤 0 ❌
13 runs 13 ✅ 0 💤 0 ❌

Results for commit 0fc9e9d.

codacy-production · 2024-08-16T13:30:08Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `b252aca`¹	✅ 91.43%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`b252aca`)	Report Missing	Report Missing	Report Missing
Head commit (`0fc9e9d`)	3688	3010	81.62%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#491)	35	32	91.43%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2024-08-16T13:33:14Z

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.42%. Comparing base (eab3340) to head (0fc9e9d).
Report is 9 commits behind head on main.

Files	Patch %	Lines
src/commands/cluster.mjs	0.00%	2 Missing ⚠️
src/commands/network.mjs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   81.40%   81.42%   +0.02%     
==========================================
  Files          35       35              
  Lines        4414     4414              
  Branches      755      755              
==========================================
+ Hits         3593     3594       +1     
+ Misses        819      818       -1     
  Partials        2        2

Files	Coverage Δ
src/commands/flags.mjs	`95.16% <ø> (ø)`
src/commands/node.mjs	`79.66% <100.00%> (ø)`
src/core/account_manager.mjs	`77.25% <100.00%> (ø)`
src/core/constants.mjs	`94.44% <100.00%> (ø)`
src/core/helpers.mjs	`92.06% <100.00%> (ø)`
src/core/k8.mjs	`86.47% <100.00%> (ø)`
src/core/logging.mjs	`57.14% <ø> (ø)`
src/core/platform_installer.mjs	`90.24% <100.00%> (ø)`
src/core/templates.mjs	`77.77% <100.00%> (ø)`
src/commands/network.mjs	`54.81% <0.00%> (ø)`
... and 1 more

... and 1 file with indirect coverage changes

## [0.28.0](v0.27.0...v0.28.0) (2024-08-26) ### Features * add freeze account ([#436](#436)) ([8fe5a41](8fe5a41)) * enhance node add to work with staking and dynamic address book ([#469](#469)) ([b452599](b452599)) * use k8s configMaps to mount files during solo network deploy ([#345](#345)) ([af27f16](af27f16)) ### Bug Fixes * hugo jsdoc failure ([#498](#498)) ([ff07413](ff07413)) * reduce number of account used e2e init account test ([#477](#477)) ([51d7ade](51d7ade)) * Resolve various problems to enable tests from local-node and smart-contracts to run agains solo network ([#402](#402)) ([c99d881](c99d881)) * use path.join instead of forward slashes to support Windows ([#491](#491)) ([82a5053](82a5053))

swirlds-automation · 2024-08-26T14:58:19Z

🎉 This PR is included in version 0.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jeromy-cannon added 2 commits August 16, 2024 14:05

use path join to avoid windows unit test failures

d5d29a0

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

path.join changes to support windows

0076ba8

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> # Conflicts: # src/core/profile_manager.mjs # test/unit/core/profile_manager.test.mjs

jeromy-cannon self-assigned this Aug 16, 2024

jeromy-cannon requested a review from JeffreyDallas August 16, 2024 13:14

missing import

0fc9e9d

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

jeromy-cannon marked this pull request as ready for review August 16, 2024 13:23

jeromy-cannon requested review from leninmehedy and a team as code owners August 16, 2024 13:23

JeffreyDallas approved these changes Aug 16, 2024

View reviewed changes

jeromy-cannon merged commit 82a5053 into main Aug 16, 2024
32 of 33 checks passed

jeromy-cannon deleted the 00490-path-join branch August 16, 2024 14:10

swirlds-automation added the released label Aug 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use path.join instead of forward slashes to support Windows #491

fix: use path.join instead of forward slashes to support Windows #491

jeromy-cannon commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

codacy-production bot commented Aug 16, 2024

codecov bot commented Aug 16, 2024 •

edited

Loading

swirlds-automation commented Aug 26, 2024

fix: use path.join instead of forward slashes to support Windows #491

fix: use path.join instead of forward slashes to support Windows #491

Conversation

jeromy-cannon commented Aug 16, 2024

Description

Related Issues

github-actions bot commented Aug 16, 2024

Unit Test Results - Linux

github-actions bot commented Aug 16, 2024

Unit Test Results - Windows

github-actions bot commented Aug 16, 2024

E2E Node PEM Stop Tests Coverage Report

github-actions bot commented Aug 16, 2024

E2E Relay Tests Coverage Report

github-actions bot commented Aug 16, 2024

E2E Node PFX Kill Tests Coverage Report

github-actions bot commented Aug 16, 2024

E2E Tests Coverage Report

github-actions bot commented Aug 16, 2024

E2E Node Local Build Tests Coverage Report

github-actions bot commented Aug 16, 2024

E2E Node Add Tests Coverage Report

github-actions bot commented Aug 16, 2024

E2E Mirror Node Tests Coverage Report

codacy-production bot commented Aug 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented Aug 16, 2024 • edited Loading

Codecov Report

swirlds-automation commented Aug 26, 2024

codecov bot commented Aug 16, 2024 •

edited

Loading