Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(functionality): removed the 'z' from the 'tar' command on the K8.copyFrom #561

Merged

Conversation

instamenta
Copy link
Contributor

Description

Removed the 'z' from the 'tar' command on the K8.copyFrom method in order to disable the compression

Related Issues

  • Closes # 57

…rder to disable the compression

Signed-off-by: instamenta <instamenta@abv.bg>
@instamenta instamenta requested review from leninmehedy and a team as code owners September 11, 2024 07:27
@instamenta instamenta linked an issue Sep 11, 2024 that may be closed by this pull request
1 task
@instamenta instamenta self-assigned this Sep 11, 2024
Copy link
Contributor

Unit Test Results - Linux

  1 files  ±0   19 suites  ±0   28s ⏱️ +3s
122 tests ±0  122 ✅ ±0  0 💤 ±0  0 ❌ ±0 
148 runs  ±0  148 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 94969d7. ± Comparison against base commit 853eb9e.

Copy link
Contributor

Unit Test Results - Windows

  1 files  ±0   19 suites  ±0   53s ⏱️ -1s
122 tests ±0  122 ✅ ±0  0 💤 ±0  0 ❌ ±0 
148 runs  ±0  148 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 94969d7. ± Comparison against base commit 853eb9e.

Copy link
Contributor

E2E Relay Tests Coverage Report

1 files  ±0  1 suites  ±0   2m 32s ⏱️ -9s
6 tests ±0  6 ✅ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  7 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 94969d7. ± Comparison against base commit 853eb9e.

Copy link
Contributor

E2E Node Local Build Tests Coverage Report

10 tests  ±0   10 ✅ ±0   2m 23s ⏱️ -3s
 2 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 94969d7. ± Comparison against base commit 853eb9e.

Copy link
Contributor

E2E Tests Coverage Report

58 tests  ±0   58 ✅ ±0   3m 38s ⏱️ -10s
 9 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 94969d7. ± Comparison against base commit 853eb9e.

Copy link
Contributor

E2E Mirror Node Tests Coverage Report

 1 files  ±0   1 suites  ±0   3m 35s ⏱️ -8s
13 tests ±0  13 ✅ ±0  0 💤 ±0  0 ❌ ±0 
14 runs  ±0  14 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 94969d7. ± Comparison against base commit 853eb9e.

Copy link
Contributor

github-actions bot commented Sep 11, 2024

E2E Node PEM Kill Tests Coverage Report

13 tests  ±0   13 ✅ ±0   2m 41s ⏱️ -7s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 94969d7. ± Comparison against base commit 853eb9e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 11, 2024

E2E Node PEM Stop Tests Coverage Report

13 tests  ±0   13 ✅ ±0   2m 36s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 94969d7. ± Comparison against base commit 853eb9e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

E2E Node Update Tests Coverage Report

12 tests  ±0   12 ✅ ±0   5m 26s ⏱️ -5s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 94969d7. ± Comparison against base commit 853eb9e.

Copy link
Contributor

E2E Node Delete Tests Coverage Report

10 tests  ±0   10 ✅ ±0   6m 16s ⏱️ +5s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 94969d7. ± Comparison against base commit 853eb9e.

Copy link
Contributor

E2E Node Add Tests Coverage Report

22 tests  ±0   22 ✅ ±0   13m 54s ⏱️ +9s
 2 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 94969d7. ± Comparison against base commit 853eb9e.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (853eb9e) 4031 3166 78.54%
Head commit (94969d7) 4035 (+4) 3172 (+6) 78.61% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#561) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.19%. Comparing base (853eb9e) to head (94969d7).
Report is 26 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   83.15%   83.19%   +0.04%     
==========================================
  Files          36       36              
  Lines        4815     4815              
  Branches      667      742      +75     
==========================================
+ Hits         4004     4006       +2     
+ Misses        811      809       -2     
Files with missing lines Coverage Δ
src/core/k8.mjs 87.71% <100.00%> (+0.25%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit 796474b into main Sep 11, 2024
42 checks passed
@jeromy-cannon jeromy-cannon deleted the 00057-fix-copyto-and-copyfrom-command-in-k8-class branch September 11, 2024 07:59
swirlds-automation added a commit that referenced this pull request Sep 17, 2024
## [0.30.0](v0.29.0...v0.30.0) (2024-09-17)

### Features

* add node add-prepare and node add-execute commands ([#533](#533)) ([a184775](a184775))
* add support for attach jvm debugger ([#549](#549)) ([35a0075](35a0075))
* add the autogen tool to easily add e2e tests and run it for the first time & fix copyFrom ([#566](#566)) ([e6c79eb](e6c79eb))
* **network node livecheck:** implement a functionality to determine network node activeness with prometheus metrics ([#567](#567)) ([6120775](6120775))
* remove pfx support ([#537](#537)) ([aff5f63](aff5f63))

### Bug Fixes

* aligned test names to naming pattern ([#554](#554)) ([365f724](365f724))
* download application.properties file if it was generated by hedera app during handling address book change ([#571](#571)) ([35c73d8](35c73d8))
* **functionality:** removed the 'z' from the 'tar' command on the K8.copyFrom ([#561](#561)) ([796474b](796474b))
* have update readme run after version calculation in deploy and release ([#586](#586)) ([42e1685](42e1685))
* jsdoc errors due to unrecognized format ([#557](#557)) ([da7113b](da7113b))
* remove of using agreement key in hedera repo test ([#563](#563)) ([05c5517](05c5517))
* separate repeated steps as individual functions ([#562](#562)) ([dcbbe5e](dcbbe5e))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix copyTo and copyFrom command in K8 class
3 participants