Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network node livecheck): implement a functionality to determine network node activeness with prometheus metrics #567

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Sep 12, 2024

Description

Implemented functionality that utilizes the node root container prometheus metrics endpoint to determine node's activeness

Related Issues

…ode root container prometheus metrics

Signed-off-by: instamenta <instamenta@abv.bg>
@instamenta instamenta self-assigned this Sep 12, 2024
@instamenta instamenta requested review from leninmehedy and a team as code owners September 12, 2024 12:40
@instamenta instamenta linked an issue Sep 12, 2024 that may be closed by this pull request
5 tasks
Copy link
Contributor

github-actions bot commented Sep 12, 2024

Unit Test Results - Linux

  1 files   19 suites   28s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
148 runs  148 ✅ 0 💤 0 ❌

Results for commit 52aef25.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Unit Test Results - Windows

  1 files   19 suites   53s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
148 runs  148 ✅ 0 💤 0 ❌

Results for commit 52aef25.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

E2E Relay Tests Coverage Report

1 files  1 suites   2m 41s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs  7 ✅ 0 💤 0 ❌

Results for commit 52aef25.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

E2E Node PEM Kill Tests Coverage Report

13 tests   13 ✅  3m 16s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 52aef25.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

E2E Node PEM Stop Tests Coverage Report

13 tests   13 ✅  3m 24s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 52aef25.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

E2E Node Local Build Tests Coverage Report

10 tests   10 ✅  2m 22s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit 52aef25.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

E2E Mirror Node Tests Coverage Report

 1 files   1 suites   3m 42s ⏱️
13 tests 13 ✅ 0 💤 0 ❌
14 runs  14 ✅ 0 💤 0 ❌

Results for commit 52aef25.

♻️ This comment has been updated with latest results.

Copy link
Contributor

E2E Tests Coverage Report

58 tests   58 ✅  3m 39s ⏱️
 9 suites   0 💤
 1 files     0 ❌

Results for commit 49159ac.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

E2E Node Update Tests Coverage Report

12 tests   12 ✅  5m 10s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 52aef25.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

E2E Node Delete Tests Coverage Report

10 tests   10 ✅  6m 12s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 52aef25.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

E2E Node Add Tests Coverage Report

22 tests   22 ✅  12m 1s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit 52aef25.

♻️ This comment has been updated with latest results.

… healthchekcs

Signed-off-by: instamenta <instamenta@abv.bg>
Signed-off-by: instamenta <instamenta@abv.bg>
Copy link
Contributor

github-actions bot commented Sep 13, 2024

E2E Standard Tests Coverage Report

 1 files   9 suites   4m 29s ⏱️
58 tests 58 ✅ 0 💤 0 ❌
59 runs  59 ✅ 0 💤 0 ❌

Results for commit 52aef25.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Sep 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for ae97fc01 91.53%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ae97fc0) Report Missing Report Missing Report Missing
Head commit (52aef25) 3973 3252 81.85%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#567) 59 54 91.53%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 91.80328% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.77%. Comparing base (32dcf0c) to head (52aef25).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/node.mjs 91.52% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   82.54%   81.77%   -0.78%     
==========================================
  Files          36       37       +1     
  Lines        4720     4767      +47     
  Branches      674      679       +5     
==========================================
+ Hits         3896     3898       +2     
- Misses        824      869      +45     
Files with missing lines Coverage Δ
src/core/enumerations.mjs 100.00% <100.00%> (ø)
test/e2e/e2e_node_util.js 86.81% <ø> (-1.10%) ⬇️
src/commands/node.mjs 82.64% <91.52%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

Signed-off-by: instamenta <instamenta@abv.bg>
Signed-off-by: instamenta <instamenta@abv.bg>
Signed-off-by: instamenta <instamenta@abv.bg>
@jeromy-cannon jeromy-cannon merged commit 6120775 into main Sep 14, 2024
38 of 39 checks passed
@jeromy-cannon jeromy-cannon deleted the 00209-update-checks-for-network-node-active-to-leverage-podconditionready branch September 14, 2024 08:41
swirlds-automation added a commit that referenced this pull request Sep 17, 2024
## [0.30.0](v0.29.0...v0.30.0) (2024-09-17)

### Features

* add node add-prepare and node add-execute commands ([#533](#533)) ([a184775](a184775))
* add support for attach jvm debugger ([#549](#549)) ([35a0075](35a0075))
* add the autogen tool to easily add e2e tests and run it for the first time & fix copyFrom ([#566](#566)) ([e6c79eb](e6c79eb))
* **network node livecheck:** implement a functionality to determine network node activeness with prometheus metrics ([#567](#567)) ([6120775](6120775))
* remove pfx support ([#537](#537)) ([aff5f63](aff5f63))

### Bug Fixes

* aligned test names to naming pattern ([#554](#554)) ([365f724](365f724))
* download application.properties file if it was generated by hedera app during handling address book change ([#571](#571)) ([35c73d8](35c73d8))
* **functionality:** removed the 'z' from the 'tar' command on the K8.copyFrom ([#561](#561)) ([796474b](796474b))
* have update readme run after version calculation in deploy and release ([#586](#586)) ([42e1685](42e1685))
* jsdoc errors due to unrecognized format ([#557](#557)) ([da7113b](da7113b))
* remove of using agreement key in hedera repo test ([#563](#563)) ([05c5517](05c5517))
* separate repeated steps as individual functions ([#562](#562)) ([dcbbe5e](dcbbe5e))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update checks for Network Node ACTIVE to leverage PodCondition[Ready]
3 participants