Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quiet flag #621

Merged
merged 9 commits into from
Sep 30, 2024
Merged

feat: add quiet flag #621

merged 9 commits into from
Sep 30, 2024

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • add quiet flag to command that might need prompt to set flags with unknown values

Related Issues

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…uite-mode

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	src/commands/mirror_node.mjs
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Unit Test Results - Linux

  1 files  ±0   19 suites  ±0   27s ⏱️ ±0s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1fcaa1f. ± Comparison against base commit 5fa1b7d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Unit Test Results - Windows

  1 files  ±0   19 suites  ±0   1m 2s ⏱️ +4s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1fcaa1f. ± Comparison against base commit 5fa1b7d.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link
Contributor

E2E Test Report

 10 files  ±0   20 suites  ±0   47m 47s ⏱️ - 1m 10s
168 tests ±0  168 ✅ ±0  0 💤 ±0  0 ❌ ±0 
171 runs  ±0  171 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a24a18a. ± Comparison against base commit 3f838f6.

Copy link
Contributor

github-actions bot commented Sep 21, 2024

E2E Test Report

 10 files  ±0   20 suites  ±0   49m 25s ⏱️ +27s
170 tests ±0  170 ✅ ±0  0 💤 ±0  0 ❌ ±0 
173 runs  ±0  173 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1fcaa1f. ± Comparison against base commit 5fa1b7d.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Sep 21, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5fa1b7d) 4070 3295 80.96%
Head commit (1fcaa1f) 4082 (+12) 3304 (+9) 80.94% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#621) 9 6 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.78%. Comparing base (5fa1b7d) to head (1fcaa1f).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/node.mjs 0.00% 4 Missing ⚠️
src/commands/prompts.mjs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
- Coverage   80.83%   80.78%   -0.06%     
==========================================
  Files          37       37              
  Lines        4885     4896      +11     
  Branches      684      689       +5     
==========================================
+ Hits         3949     3955       +6     
- Misses        936      941       +5     
Files with missing lines Coverage Δ
src/commands/flags.mjs 96.10% <100.00%> (+0.05%) ⬆️
src/commands/mirror_node.mjs 66.24% <ø> (ø)
src/commands/network.mjs 68.94% <ø> (ø)
src/commands/relay.mjs 73.13% <100.00%> (+0.40%) ⬆️
test/e2e/e2e_node_util.js 86.95% <100.00%> (+0.14%) ⬆️
test/test_add.mjs 100.00% <100.00%> (ø)
test/test_util.js 91.15% <ø> (ø)
src/commands/prompts.mjs 63.01% <50.00%> (-0.19%) ⬇️
src/commands/node.mjs 80.18% <0.00%> (-0.27%) ⬇️

Impacted file tree graph

…uite-mode

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	src/commands/flags.mjs
Copy link
Contributor

@jeromy-cannon jeromy-cannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

…uite-mode

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@jeromy-cannon jeromy-cannon merged commit b068c8f into main Sep 30, 2024
33 of 35 checks passed
@jeromy-cannon jeromy-cannon deleted the 0580-D-quite-mode branch September 30, 2024 17:15
swirlds-automation added a commit that referenced this pull request Oct 4, 2024
## [0.31.0](v0.30.1...v0.31.0) (2024-10-04)

### Features

* Add '--mirror-node-version' flag to override default mirror node version ([#616](#616)) ([e4932c4](e4932c4))
* add quiet flag ([#621](#621)) ([b068c8f](b068c8f))
* convert hugo docs workflow calls to use Taskfile task ([#642](#642)) ([ae8d8bb](ae8d8bb))
* ensured user-provided values file takes precedence over solo-generated values ([#615](#615)) ([1b0ffc9](1b0ffc9))
* **logging:** Add the new custom process output class and inject it into the default list renderer options ([#622](#622)) ([efa1783](efa1783))
* separate commands for solo node delete ([#597](#597)) ([b251276](b251276))
* Separate network upgrade and freeze from node update/add/delete command ([#628](#628)) ([9b17937](9b17937))

### Bug Fixes

* Direct calling of node stop and start commands ([#636](#636)) ([7749b04](7749b04))
* **docs:** resolve issues due to npx in taskfile for the custom-network-config example ([038e6df](038e6df))
* jsdoc failed but ci job not failed ([#608](#608)) ([3f838f6](3f838f6))
* specify jvm env variables explicitly for local profile ([#405](#405)) ([3db7e08](3db7e08))
* **tests:** start Kind cluster on demand if not having a kube config errors ([#624](#624)) ([538e40d](538e40d))
* upgrade eslint config away from abandoned plugin ([#643](#643)) ([84d3dc5](84d3dc5))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --quiet mode to suppress all command/subcommand prompting
3 participants