ui: Adds easily accessible env for user settable 'debug' settings
#5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a synchronous only 'debug' setting accessor, uses localStorage first and falls back to ember config.
meirish
approved these changes
Apr 16, 2019
johncowen
added a commit
that referenced
this pull request
Apr 29, 2019
…5668) This is a synchronous only 'debug' setting accessor, uses localStorage first and falls back to ember config.
johncowen
added a commit
that referenced
this pull request
May 1, 2019
…5668) This is a synchronous only 'debug' setting accessor, uses localStorage first and falls back to ember config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a synchronous only 'debug' setting accessor, uses localStorage
first and falls back to ember config.
Essentially this is 'feature flags' for the UI, but as we can't/don't use a third party '...as a service' we use localStorage instead. This is just a slight expansion on what we had previously to make it easier to use. Future work may involve an injectable Service exposing this for usage in JS classes, plus a helper for usage in templates.
Lastly, please note these are largely temporary settings/forking, and the settings themselves are extremely likely to be removed in future. They are purely to give us options if we need to debug new features with users, hence 'debug' settings, which is why we don't want a proper interface allow users to change them easily (right now at least).
'Proper' user settings will continue to be available in the Settings area of the UI.