ui: Provide options for event source runners (behind flags) #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd say we should probably drop this from 1.5.0 if I understand it correctly -- just given the priority of getting in some of the other PRs. Going to proactively drop it from the milestone but can definitely re-add if we definitely need it. |
|
Yep no prob, I almost didn't add it, lets chat later. |
johncowen
force-pushed
the
feature/ui-event-source-runners
branch
from
fcf8c4e to
e9743fd
Compare
johncowen
force-pushed
the
feature/ui-event-source-runners
branch
from
e9743fd to
f271294
Compare
johncowen
force-pushed
the
feature/ui-event-source-runners
branch
from
f271294 to
1f28117
Compare
johncowen
added a commit
that referenced
this pull request
Jun 21, 2019
johncowen
added a commit
that referenced
this pull request
Aug 22, 2019
johncowen
added a commit
that referenced
this pull request
Aug 29, 2019
johncowen
added a commit
that referenced
this pull request
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 3 more options for How it works for EventSources whilst maintaining the same How you use it
None of these extra options are enabled by default but give us options for debugging/profiling. Each can be enabled by setting an 'env' var at runtime yet aren't easily accessible to the end user. (see #5668)