Fix dns service SRV lookup when service address is a fqdn

[tionebsalocin]

Refactor dns to have same behavior between A and SRV.
Current implementation returns the node name instead of the service
address.
With this fix when querying for SRV record service address is return in
the SRV record.
And when performing a simple dns lookup it returns a CNAME to the
service address.
(continuation of #6252)

Huge list of commits due to rebase on release/1-6

[mkeeler]

Overall this PR is amazing. The DNS code has been in need of breaking up into more isolated functions for some time so thank you for taking that on.

I have a number of comments and questions inline but one big request is that this PR be rebased against the release/1-6 branch. Not a whole lot has changed with the DNS server in that branch but there is one fundamental addition of service level tagged addressing which would definitely be relevant for this PR.

In general pretty much anywhere that you would access the node address you should call d.agent.TranslateAddress(dc, <node address>, <node tagged addresses>), when you need the service address you use d.agent.TranslateServiceAddress(dc, <service address>, <service tagged addresses>) and when you need the port (such as for SRV RRs) you can call d.agent.TranslateServicePort(dc, <service port>, <service tagged addresses>).

[hanshasselberg]

@tionebsalocin gentle ping - would you be able to make the changes that came up during our review?

[ShimmerGlass]

@i0rek, @tionebsalocin is on vacation rn but we will look at this soon

[tionebsalocin]

@mkeeler Should I create a new PR on release/1-6 instead?

[mkeeler]

@tionebsalocin You should be able to edit the PR and change the target branch to release/1-6. No need for a separate PR.

[mkeeler]

I just went ahead and retargeted myself.

[mkeeler]

It looks like the rebase may have lost a few things. There are replies where you said you updated things but the update doesn't seem to be there. Additionally there is one location where some git conflict stuff is still lingering.

[pierresouchay]

@tionebsalocin Possible to have a look to fix this?

[mkeeler]

Just a few more comments but this is super close to being ready to merge.

[tionebsalocin]

@mkeeler @pierresouchay A new PR has been created to implement requested fixes (#6792 )

[ghost]

Hey there,

This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days.

If you are still experiencing problems, or still have questions, feel free to open a new one 👍.