-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dns service SRV lookup when service address is a fqdn #6792
Conversation
a7088ca
to
43347df
Compare
9691c2a
to
0a9aff5
Compare
Refactor dns to have same behavior between A and SRV. Current implementation returns the node name instead of the service address. With this fix when querying for SRV record service address is return in the SRV record. And when performing a simple dns lookup it returns a CNAME to the service address.
0a9aff5
to
0e9a2e5
Compare
Note: Contributor License has already been signed. I don't know why it is not validated here |
@tionebsalocin Is the email you used to author this commit ( |
Hello @crhino, I've added this email to my account but still enable to submit the form (all field are pre-filled and not editable). Any suggestion on what I should do from here? |
@tionebsalocin I kicked the CLA check again and it's happy with you this time! I think @mkeeler was going to look over this once more, thanks for your effort here! |
Yep, looking now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for all your work on this.
Hey there, This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days. If you are still experiencing problems, or still have questions, feel free to open a new one 👍. |
Refactor dns to have same behavior between A and SRV.
Current implementation returns the node name instead of the service
address.
With this fix when querying for SRV record service address is return in
the SRV record.
And when performing a simple dns lookup it returns a CNAME to the
service address.
(For context history: #6252 and #6283)