ui: Mark gateway retrieval as not reconcilable #8334
Conversation
| switch (method) { | ||
| case 'findGatewayBySlug': | ||
| switch (true) { | ||
| case method === 'findGatewayBySlug' || method.indexOf('for-service') !== -1: |
There was a problem hiding this comment.
Seems odd that method could be either a camelCase or hyphen-delimited string? This should likely be an if statement instead of switch(true)...
There was a problem hiding this comment.
Hey @mikemorris ,
Seems odd that method could be either a camelCase or hyphen-delimited string?
There were two different ways of starting up a blocking query, part of the work proceeding this was to bring this back to there only being one way to start up a blocking query, no matter which ember 'thing' you were doing it from (routes/controllers/components/templates). We did it like this originally to avoid going off on a tangent whilst trying to move forwards with a feature a while back in #7967 .
The current way of marking these types of responses are soon to be moved to the adapters so this kind of configuration is kept all together with the rest of the request configuration.
I'll be PRing this 'do it in the adapter' approach shortly hopefully. If everything goes well there'll be no need to merge this anymore. This PR was only incase it was required whilst I wasn't around.
If that other PR doesn't happen then we can merge this in.
|
Just a quick note here, either this or #8384 needs to go in before a 1.8.1 release. |
|
Closing this as this was just a temporary fix waiting on #8384 |
This PR excludes any request that responds with a partial set of results from reconciliation (if the response set is a partial response it shouldn't clean up any records that aren't in the response)
The current way of marking these types of responses are soon to be moved to the adapters so this kind of configuration is kept all together with the rest of the request configuration.