ui: Use X-Range header as a signal as to whether to reconcile the ember-data store #8384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 27, 2020 09:43
Previously we used a `shouldReconcile` method in order to decide whether a response should trigger a reconciliation of the frontend ember-data 'source of truth' or not. It's a lot nicer/clearer if this 'flag' can be set alongside the HTTP request information, moreover we almost have the same functionality in `If-Range`/`Partial Content` HTTP functionality. Here we partly follow this HTTP semantics but use a custom `X-Range` header instead.
This header value controls whether ember-data should reconcile its local store/data or not.
johncowen
commented
Jul 27, 2020
| ? ` | ||
| X-Range: ${filter}` | ||
| : `` | ||
| } |
There was a problem hiding this comment.
Ouch just found out how prettier has 'prettified' our nice one-liner conditional, it looked nicer than this beforehand honest! Joking aside, I think this is fine, we could add some prettier ignores in here but I don't think its worth it.
|
🍒✅ Cherry pick of commit 77b4d8f onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jul 29, 2020
…er-data store (#8384) * ui: Use `X-Range` header/meta to decide whether to reconcile or not Previously we used a `shouldReconcile` method in order to decide whether a response should trigger a reconciliation of the frontend ember-data 'source of truth' or not. It's a lot nicer/clearer if this 'flag' can be set alongside the HTTP request information, moreover we almost have the same functionality in `If-Range`/`Partial Content` HTTP functionality. Here we partly follow this HTTP semantics but use a custom `X-Range` header instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used a
shouldReconcilemethod in order to decide whether a response should trigger a reconciliation of the frontend ember-data 'source of truth' or not.It's a lot nicer/clearer if this 'flag' can be set alongside the HTTP request information, moreover we almost have the same functionality in
If-Range/Partial ContentHTTP functionality.Here we partly follow these HTTP semantics but use a custom
X-Rangeheader instead.Additional note here, we are using 'header to meta' approach more and more for various little details, it would be nice to formalise this approach a little more. In fact, the code surrounding it is from the very beginnings of the Consul UI previous to the adapter cleanup we did in #5637 (which actually mentions a desire to do a similar cleanup of the serializer layer)
This PR is an alternative/replacement to #8334