Upgrade Ember to 5.12.0 #2618
Upgrade Ember to 5.12.0 #2618
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -3,7 +3,7 @@ | |||
| "packages": [ | |||
| { | |||
| "name": "ember-cli", | |||
| "version": "5.9.0", | |||
| "version": "5.12.0", | |||
There was a problem hiding this comment.
this config is wrong it should be updated to similar to this https://github.com/hashicorp/cloud-ui/blob/main/addons/vault-common/config/ember-cli-update.json
and if you are updating it you should run ember-cli-update to update the blueprint as well same goes for the apps unless you are planning to do follow up PR
There was a problem hiding this comment.
Thanks for the feedback. These changes across the packages were made using ember-cli-update. If there is something about the changes that makes that not seem the case, please let me know.
Also in terms of the formatting of the file, can you clarify what alignments you would like to see? Should they have a different format because of the v2 addon conversion?
There was a problem hiding this comment.
this config is most likely remained unchanged since hds migrated to v2 addon, but v2 addon follows it's own blueprint, so this whole config needs to be updated to similar format I linked above
| @@ -3,7 +3,7 @@ | |||
| "packages": [ | |||
| { | |||
| "name": "ember-cli", | |||
| "version": "5.9.0", | |||
| "version": "5.12.0", | |||
There was a problem hiding this comment.
this config is wrong it should be updated to similar to this https://github.com/hashicorp/cloud-ui/blob/main/addons/vault-common/config/ember-cli-update.json
and if you are updating it you should run ember-cli-update to update the blueprint as well same goes for the apps unless you are planning to do follow up PR
| @@ -3,7 +3,7 @@ | |||
| "packages": [ | |||
| { | |||
| "name": "ember-cli", | |||
| "version": "5.9.0", | |||
| "version": "5.12.0", | |||
There was a problem hiding this comment.
you shouldn't bump this manually but by running ember-cli-update
| @@ -3,7 +3,7 @@ | |||
| "packages": [ | |||
| { | |||
| "name": "ember-cli", | |||
| "version": "5.9.0", | |||
| "version": "5.12.0", | |||
There was a problem hiding this comment.
you shouldn't bump this manually but by running ember-cli-update
📌 Summary
If merged, this PR would upgrade Ember from
5.9.0to the latest stable released version of5.12.0.🔗 External links
Jira ticket: HDS-4248
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.