Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry module object #1001

Closed
wants to merge 2 commits into from
Closed

Conversation

kd-hcp
Copy link

@kd-hcp kd-hcp commented Nov 11, 2024

Description

Updated the RegistryModule structure in registry_module.go to include the "relation" NoCodeModules if it included in the returned json. Omitempty was included to ignore this in the event the json return does not include the no-code-module relationship.

Testing plan

Make a call to RegistryModules.List().
The returned object will now include the param NoCodeModules which is an array object containing any associated no code module data related to the parent module.

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestFunctionsAffectedByChange

=== RUN   TestRegistryModulesListCommit
    registry_module_integration_test.go:681: Skipping test related to a HCP Terraform beta feature. Set ENABLE_BETA=1 to run.
--- SKIP: TestRegistryModulesListCommit (0.00s)
PASS
ok      github.com/hashicorp/go-tfe     0.287s

...

Copy link

hashicorp-cla-app bot commented Nov 11, 2024

CLA assistant check
All committers have signed the CLA.

@kd-hcp kd-hcp requested a review from brandonc November 11, 2024 18:15
@brandonc
Copy link
Collaborator

I think this is being added in #1003

@kd-hcp
Copy link
Author

kd-hcp commented Nov 19, 2024

I think this is being added in #1003

so are you not taking my change because someone made the change after me?

@brandonc
Copy link
Collaborator

Right, I'm saying this duplicates a line of code in a PR that was already merged

@brandonc brandonc closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants