Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inclusion of no-code module when listing modules #1003

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

paladin-devops
Copy link
Contributor

@paladin-devops paladin-devops commented Nov 14, 2024

Description

This PR enables the use of the inclusion of related resources for RegistryModule. The only one added for support in this PR is the no-code module relation.

Testing plan

  1. Create a no-code module in the registry
  2. Attempt to list it using the List endpoint of this client, by setting the Include field of the list options

@paladin-devops paladin-devops self-assigned this Nov 14, 2024
@paladin-devops paladin-devops force-pushed the list-registry-module-filter branch from db7aad5 to 243c1dc Compare November 15, 2024 16:18
@paladin-devops paladin-devops marked this pull request as ready for review November 15, 2024 16:34
@paladin-devops paladin-devops force-pushed the list-registry-module-filter branch 2 times, most recently from 7002b96 to abd2f08 Compare November 18, 2024 20:36
@paladin-devops paladin-devops requested a review from a team as a code owner November 19, 2024 03:43
@paladin-devops paladin-devops force-pushed the list-registry-module-filter branch from 4c915e6 to 29be3a6 Compare November 19, 2024 03:43
@datadog-terraform-cloud-hashicorp
Copy link

datadog-terraform-cloud-hashicorp bot commented Nov 19, 2024

Datadog Report

Branch report: list-registry-module-filter
Commit report: b291884
Test service: hashicorp/go-tfe

✅ 0 Failed, 1420 Passed, 149 Skipped, 16m 18.03s Total Time
➡️ Test Sessions change in coverage: 1 no change

@paladin-devops paladin-devops force-pushed the list-registry-module-filter branch from a3dbd87 to f34b773 Compare November 19, 2024 04:20
brandonc
brandonc previously approved these changes Nov 19, 2024
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it just needs a CHANGELOG entry

@paladin-devops paladin-devops merged commit c278019 into main Nov 19, 2024
7 checks passed
@paladin-devops paladin-devops deleted the list-registry-module-filter branch November 19, 2024 18:41
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants