Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/importer-rest-api-specs: adding a swagger data workaround for https://github.com/Azure/azure-rest-api-specs/pull/21581 #1830

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Nov 16, 2022

This PR adds a temporary Swagger workaround for Azure/azure-rest-api-specs#21581 - moving the Update operation into the StreamingEndpoints package, so that the models can be reused

Unblocks hashicorp/terraform-provider-azurerm#19285

@hc-github-team-tf-azure
Copy link
Collaborator

No new resource IDs found.

@tombuildsstuff tombuildsstuff marked this pull request as ready for review November 16, 2022 11:34
@tombuildsstuff tombuildsstuff requested a review from a team November 16, 2022 11:34
@hc-github-team-tf-azure
Copy link
Collaborator

No new resource IDs found.

@tombuildsstuff tombuildsstuff added area/swagger-workarounds area/data-canonicalisation Issues around Data Normalisation/Canonicalisation labels Nov 16, 2022
@hc-github-team-tf-azure
Copy link
Collaborator

No new resource IDs found.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 6f88d65 into main Nov 16, 2022
@tombuildsstuff tombuildsstuff deleted the f/media-swagger-workaround branch November 16, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-canonicalisation Issues around Data Normalisation/Canonicalisation area/swagger-workarounds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants