Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media: fixing the Swagger Tag for consistency #21581

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

tombuildsstuff
Copy link
Contributor

The other Swagger Tags for this Operation are StreamingEndpoints, this is a typo for the Update operation and should be consistent

The other Swagger Tags for this Operation are `StreamingEndpoints`, this is a typo for
the Update operation and should be consistent
@openapi-workflow-bot
Copy link

Hi, @tombuildsstuff Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 16, 2022
    @ghost
    Copy link

    ghost commented Nov 16, 2022

    Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon.

    @tombuildsstuff
    Copy link
    Contributor Author

    @allenjzhang what's needed to get this one merged?

    @allenjzhang
    Copy link
    Member

    /azp run

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 6, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.2)] new version base version
    streamingservice.json 2020-05-01(e814adc) 2020-05-01(main)
    streamingservice.json 2021-06-01(e814adc) 2021-06-01(main)
    streamingservice.json 2021-11-01(e814adc) 2021-11-01(main)
    streamingservice.json 2022-08-01(e814adc) 2022-08-01(main)
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-metadata-2022-08 package-metadata-2022-08(e814adc) package-metadata-2022-08(main)
    package-2022-08 package-2022-08(e814adc) package-2022-08(main)
    package-account-2021-11 package-account-2021-11(e814adc) package-account-2021-11(main)
    package-2021-11 package-2021-11(e814adc) package-2021-11(main)
    package-2021-06 package-2021-06(e814adc) package-2021-06(main)
    package-2021-05 package-2021-05(e814adc) package-2021-05(main)
    package-2020-05 package-2020-05(e814adc) package-2020-05(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L30
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L30
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L76
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L76
    MissingXmsErrorResponse Response code 404 is defined without a x-ms-error-response.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L108
    MissingXmsErrorResponse Response code 404 is defined without a x-ms-error-response.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L108
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Streaming/stable/2020-05-01/streamingservice.json#L124
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Streaming/stable/2020-05-01/streamingservice.json#L124
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L209
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L209
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L209
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L209
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L209
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L209
    PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L214
    PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L214
    LroLocationHeader A 202 response should include an Location response header.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L226
    LroLocationHeader A 202 response should include an Location response header.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L226
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Streaming/stable/2020-05-01/streamingservice.json#L246
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Streaming/stable/2020-05-01/streamingservice.json#L246
    LroLocationHeader A 202 response should include an Location response header.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L274
    LroLocationHeader A 202 response should include an Location response header.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L274
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L295
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L295
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Streaming/stable/2020-05-01/streamingservice.json#L296
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Streaming/stable/2020-05-01/streamingservice.json#L296
    LroLocationHeader A 202 response should include an Location response header.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L324
    LroLocationHeader A 202 response should include an Location response header.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L324
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L342
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Streaming/stable/2020-05-01/streamingservice.json#L342
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mediaservices/resource-manager/readme.md
    tag: specification/mediaservices/resource-manager/readme.md#tag-package-metadata-2022-08
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 28 Errors, 0 Warnings failed [Detail]
    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L219:22
    ExampleUrl: stable/2020-05-01/examples/liveevent-update.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L270:22
    ExampleUrl: stable/2020-05-01/examples/liveevent-delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L320:22
    ExampleUrl: stable/2020-05-01/examples/liveevent-allocate.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L367:22
    ExampleUrl: stable/2020-05-01/examples/liveevent-start.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L423:22
    ExampleUrl: stable/2020-05-01/examples/liveevent-stop.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L470:22
    ExampleUrl: stable/2020-05-01/examples/liveevent-reset.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L682:22
    ExampleUrl: stable/2020-05-01/examples/liveoutput-delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L897:22
    ExampleUrl: stable/2020-05-01/examples/streamingendpoint-update.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L948:22
    ExampleUrl: stable/2020-05-01/examples/streamingendpoint-delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L998:22
    ExampleUrl: stable/2020-05-01/examples/streamingendpoint-start.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L1045:22
    ExampleUrl: stable/2020-05-01/examples/streamingendpoint-stop.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2020-05-01/streamingservice.json#L1101:22
    ExampleUrl: stable/2020-05-01/examples/streamingendpoint-scale.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L216:22
    ExampleUrl: stable/2021-06-01/examples/liveevent-update.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L267:22
    ExampleUrl: stable/2021-06-01/examples/liveevent-delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L317:22
    ExampleUrl: stable/2021-06-01/examples/liveevent-allocate.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L364:22
    ExampleUrl: stable/2021-06-01/examples/liveevent-start.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L420:22
    ExampleUrl: stable/2021-06-01/examples/liveevent-stop.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L467:22
    ExampleUrl: stable/2021-06-01/examples/liveevent-reset.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L676:22
    ExampleUrl: stable/2021-06-01/examples/liveoutput-delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L888:22
    ExampleUrl: stable/2021-06-01/examples/streamingendpoint-update.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L939:22
    ExampleUrl: stable/2021-06-01/examples/streamingendpoint-delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L989:22
    ExampleUrl: stable/2021-06-01/examples/streamingendpoint-start.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L1036:22
    ExampleUrl: stable/2021-06-01/examples/streamingendpoint-stop.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-06-01/streamingservice.json#L1092:22
    ExampleUrl: stable/2021-06-01/examples/streamingendpoint-scale.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-11-01/streamingservice.json#L317:22
    ExampleUrl: stable/2021-11-01/examples/liveevent-allocate.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2021-11-01/streamingservice.json#L676:22
    ExampleUrl: stable/2021-11-01/examples/liveoutput-delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2022-08-01/streamingservice.json#L317:22
    ExampleUrl: stable/2022-08-01/examples/liveevent-allocate.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Streaming/stable/2022-08-01/streamingservice.json#L774:22
    ExampleUrl: stable/2022-08-01/examples/liveoutput-delete.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 6, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking



    azure-sdk-for-js - @azure/arm-mediaservices - Approved - 14.0.0
    -	Type of parameter odataType of interface Audio_2 is changed from "#Microsoft.Media.Audio" | "#Microsoft.Media.AacAudio" to "#Microsoft.Media.Audio" | "#Microsoft.Media.AacAudio" | "#Microsoft.Media.DDAudio"
    -	Type of parameter odataType of interface Codec is changed from "#Microsoft.Media.Audio" | "#Microsoft.Media.AacAudio" | "#Microsoft.Media.Video" | "#Microsoft.Media.H265Video" | "#Microsoft.Media.CopyVideo" | "#Microsoft.Media.Image" | "#Microsoft.Media.CopyAudio" | "#Microsoft.Media.H264Video" | "#Microsoft.Media.JpgImage" | "#Microsoft.Media.PngImage" to "#Microsoft.Media.Audio" | "#Microsoft.Media.AacAudio" | "#Microsoft.Media.DDAudio" | "#Microsoft.Media.Video" | "#Microsoft.Media.H265Video" | "#Microsoft.Media.CopyVideo" | "#Microsoft.Media.Image" | "#Microsoft.Media.CopyAudio" | "#Microsoft.Media.H264Video" | "#Microsoft.Media.JpgImage" | "#Microsoft.Media.PngImage"
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8995e20. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Media [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8995e20. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.4.2` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-media [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8995e20. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.
    • ️✔️azure-resourcemanager-mediaservices [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8995e20. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/mediaservices/armmediaservices [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8995e20. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
    • ️✔️@azure/arm-mediaservices [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8995e20. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️mediaservices [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 8995e20. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.mediaservices [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 6, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/mediaservices/armmediaservices Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-mediaservices Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.Media Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-mediaservices Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-workflow-bot
    Copy link

    Hi @tombuildsstuff, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @akning-ms
    Copy link
    Contributor

    @qiaozha to confirm the JS sdk breaking change

    @qiaozha
    Copy link
    Member

    qiaozha commented Feb 13, 2023

    @raych1 Could you help take a look at the model validation error ? Thanks

    @raych1
    Copy link
    Member

    raych1 commented Feb 13, 2023

    @raych1 Could you help take a look at the model validation error ? Thanks

    Approved it as it's not caused by this PR change.

    @qiaozha qiaozha merged commit 8995e20 into Azure:main Feb 14, 2023
    @tombuildsstuff tombuildsstuff deleted the b/media-swagger-tag branch February 14, 2023 10:51
    aviyerMSFT pushed a commit to aviyerMSFT/azure-rest-api-specs that referenced this pull request Mar 22, 2023
    The other Swagger Tags for this Operation are `StreamingEndpoints`, this is a typo for
    the Update operation and should be consistent
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants