(WIP) Updating underlying bbolt #451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnoop
reviewed
Mar 27, 2021
| @@ -7,7 +7,6 @@ require ( | |||
| github.com/boltdb/bolt v1.3.1 // indirect | |||
| github.com/hashicorp/go-hclog v0.9.1 | |||
| github.com/hashicorp/go-msgpack v0.5.5 | |||
| github.com/hashicorp/raft-boltdb v0.0.0-20171010151810-6e5ba93211ea | |||
| github.com/hashicorp/raft-boltdb v0.0.0-20210326213752-22de16c8e211 | |||
There was a problem hiding this comment.
It looks like hashicorp/raft-boltdb and boltdb/bolt are only used for fuzzy tests. The dependency is a bit troublesome too, because it's a circular dependency (raft depends on raft-boltdb, which in turns depends on raft!).
I'd suggest breaking out fuzzy as its own go module, and have it depend on raft and raft-boltdb. Doing so avoids requiring raft consumers from depending on boltdb unnecessarily.
There was a problem hiding this comment.
Thank you for this suggestion and I'll get that taken care of <3
|
Resolved in #459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this is merged, and the repository tagged I will update this properly.