extract fuzzy as its own module #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzy depends on raft-boltdb, which depends on raft as well. Having fuzzy as its own module, breaks the circular dependency. Also, having `fuzzy` avoids leaking the raft-boltdb dependency and versioning constaints into consumers. This was a significant factor, as `raft-boltdb` changed storage engine in hashicorp/raft-boltdb#22. However, given raft-boltdb storage occured as a api major change, and both raft-boltdb storage engines can coexist in the same go project, so it's less of an issue now.
schristoff
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuzzy depends on raft-boltdb, which depends on raft as well. Having
fuzzy as its own module, breaks the circular dependency.
Also, having
fuzzyavoids leaking the raft-boltdb dependency andversioning constaints into consumers. This was a significant factor, as
raft-boltdbchanged storage engine inhashicorp/raft-boltdb#22. However, given
raft-boltdb storage occured as a api major change, and both raft-boltdb
storage engines can coexist in the same go project, so it's less of an
issue now.