tftypes: Enhance Type Comparisons Functionality #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update our Type interface to include UsableAs and Equal explicitly. Add placeholders for UsableAs and Equal on all types, so tests can run. Update String, Number, Bool, and DynamicPseudoType to have UsableAs implementations, and tests for those implementations. DynamicPseudoType will panic when UsableAs is called on it, because DynamicPseudoType is a type constraint, it should never be associated with a Value. This work will allow us to resolve #83.
…() into Equal() and Is() The interface now accounts for the differing semantics of Equal() and Is(), which means the dual purpose equals() method is extraneous.
Prevent issues with DynamicPsuedoType handling.
More accurate behavior after Is() refactoring and prevents panics.
… Object AttributeTypes
…actions so testing does not require adjustment
Leave descriptive comment for future travelers.
… and UsableAs() functionality
bflad
added
enhancement
… cannot be implemented outside the tftypes package
…accepts matching Type and Value
…t` having `DynamicPseudoType` as their type when unmarshaling JSON values from Terraform.
paddycarver
approved these changes
Aug 10, 2021
bflad
added a commit
that referenced
this pull request
Jan 7, 2022
Reference: #94 Reference: #99 Reference: #100 Reference: #128 Reference: #133 Reverts incorrect logic for handling DynamicPseudoType values in `tftypes`. This type information must be preserved when traversing the protocol, as Terraform CLI decodes values based on the schema information. If a concrete value type is used where DynamicPseudoType is expected, Terraform CLI will return errors such as (given an object of 4 attributes, when DynamicPseudoType is expected): ``` │ Error: ["manifest"]: msgpack: invalid code=84 decoding array length ```
bflad
added a commit
that referenced
this pull request
Jan 13, 2022
Reference: #94 Reference: #99 Reference: #100 Reference: #128 Reference: #133 Reverts incorrect logic for handling DynamicPseudoType values in `tftypes`. This type information must be preserved when traversing the protocol, as Terraform CLI decodes values based on the schema information. If a concrete value type is used where DynamicPseudoType is expected, Terraform CLI will return errors such as (given an object of 4 attributes, when DynamicPseudoType is expected): ``` │ Error: ["manifest"]: msgpack: invalid code=84 decoding array length ```
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80
Each type now implements three separate and distinct comparison methods:
(T).Equal(): performs deep type equality checks, including attribute/element types and whether attributes are optional or not.(T).Is(): performs shallow type equality checks, in that the root type is compared, but underlying attribute/element types are not.(T).UsableAs(): performs type conformance checks. This primarily checks if the target implementsDynamicPsuedoTypein a compatible manner.