tftypes: Enhance Type Comparisons Functionality #94
Commits on Aug 5, 2021
-
Start refactoring type comparisons.
Update our Type interface to include UsableAs and Equal explicitly. Add placeholders for UsableAs and Equal on all types, so tests can run. Update String, Number, Bool, and DynamicPseudoType to have UsableAs implementations, and tests for those implementations. DynamicPseudoType will panic when UsableAs is called on it, because DynamicPseudoType is a type constraint, it should never be associated with a Value. This work will allow us to resolve #83.
Commits on Aug 6, 2021
-
tftypes: Refactor List, Map, Object, primitive, Set, and Tuple equals…
…() into Equal() and Is() The interface now accounts for the differing semantics of Equal() and Is(), which means the dual purpose equals() method is extraneous.
-
tftypes: Ensure (primitive).Is() does full equality checking
Prevent issues with DynamicPsuedoType handling.
-
-
tftypes: Use (Type).Equal() instead of Is() in (Value).Equal()
More accurate behavior after Is() refactoring and prevents panics.
-
tftypes: Remove special casing for zero length Tuple ElementTypes and…
… Object AttributeTypes
-
Commits on Aug 9, 2021
-
tftypes: Use previous error messaging including English
can'tcontr……actions so testing does not require adjustment
-
tftypes: Remove panic in (primitive).UsableAs() for DynamicPseudoType
Leave descriptive comment for future travelers.
-
tftypes: Additional type constraint adjustments for split out Equal()…
… and UsableAs() functionality
-
-
.changelog: Remove breaking change about Type interface methods as it…
… cannot be implemented outside the tftypes package
-
tftypes: Allow unknown DynamicPseudoType, but ensure NewValue() only …
…accepts matching Type and Value
-
tftypes: Fixed elements of
TupleandMapand attributes of `Objec……t` having `DynamicPseudoType` as their type when unmarshaling JSON values from Terraform.